You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2012/10/03 21:00:08 UTC
[jira] [Created] (HBASE-6940) Enable GC logging by default
stack created HBASE-6940:
----------------------------
Summary: Enable GC logging by default
Key: HBASE-6940
URL: https://issues.apache.org/jira/browse/HBASE-6940
Project: HBase
Issue Type: Improvement
Components: Admin
Reporter: stack
Priority: Critical
Fix For: 0.96.0
I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-6940) Enable GC logging by default
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu reassigned HBASE-6940:
-----------------------------
Assignee: Ted Yu
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Assignee: Ted Yu
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6940-trunk.txt, 6940-v2.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6940) Enable GC logging by default
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472800#comment-13472800 ]
Hadoop QA commented on HBASE-6940:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12548465/6940-v2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 81 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3024//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3024//console
This message is automatically generated.
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6940-trunk.txt, 6940-v2.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6940) Enable GC logging by default
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472902#comment-13472902 ]
Hudson commented on HBASE-6940:
-------------------------------
Integrated in HBase-TRUNK #3438 (See [https://builds.apache.org/job/HBase-TRUNK/3438/])
HBASE-6940 Enable GC logging by default (Revision 1396399)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/conf/hbase-env.sh
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Assignee: Ted Yu
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6940-trunk.txt, 6940-v2.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6940) Enable GC logging by default
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472749#comment-13472749 ]
stack commented on HBASE-6940:
------------------------------
That would work but fix the comments. They don't make sense now the default is these environment variables are on by default.
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6940-trunk.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6940) Enable GC logging by default
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-6940:
--------------------------
Attachment: 6940-v2.txt
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6940-trunk.txt, 6940-v2.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6940) Enable GC logging by default
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6940:
-------------------------
Attachment: 6940-what-was-committed.txt
What was committed.
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Assignee: Ted Yu
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6940-trunk.txt, 6940-v2.txt, 6940-what-was-committed.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6940) Enable GC logging by default
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472898#comment-13472898 ]
Hudson commented on HBASE-6940:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #215 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/215/])
HBASE-6940 Enable GC logging by default (Revision 1396399)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/conf/hbase-env.sh
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Assignee: Ted Yu
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6940-trunk.txt, 6940-v2.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HBASE-6940) Enable GC logging by default
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reopened HBASE-6940:
--------------------------
Let me reopen this and just back it out. Its obnoxious as is. Lets fix it in HBASE-6975.
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Assignee: Ted Yu
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6940-trunk.txt, 6940-v2.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6940) Enable GC logging by default
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472770#comment-13472770 ]
stack commented on HBASE-6940:
------------------------------
+1
On commit put this line:
{code}
+export HBASE_USE_GC_LOGFILE=true
{code}
... before the uncommented HBASE_OPTS
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6940-trunk.txt, 6940-v2.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6940) Enable GC logging by default
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473939#comment-13473939 ]
Hudson commented on HBASE-6940:
-------------------------------
Integrated in HBase-TRUNK #3444 (See [https://builds.apache.org/job/HBase-TRUNK/3444/])
HBASE-6940 Enable GC logging by default: REVERT (Revision 1396919)
Result = FAILURE
stack :
Files :
* /hbase/trunk/conf/hbase-env.sh
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Assignee: Ted Yu
> Priority: Critical
> Attachments: 6940-trunk.txt, 6940-v2.txt, 6940-what-was-committed.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6940) Enable GC logging by default
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-6940:
--------------------------
Status: Patch Available (was: Open)
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6940-trunk.txt, 6940-v2.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6940) Enable GC logging by default
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470745#comment-13470745 ]
Ted Yu commented on HBASE-6940:
-------------------------------
To do this, we need to specify the path to GC log:
{code}
-Xloggc:/apache/hbase/logs/gc-hbase.log
{code}
Should a variable, such as HBASE_GC_LOG_PATH, be introduced so that user can specify the location ?
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Priority: Critical
> Fix For: 0.96.0
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6940) Enable GC logging by default
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470750#comment-13470750 ]
stack commented on HBASE-6940:
------------------------------
We have a logging dir define already. We'll reuse that.
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Priority: Critical
> Fix For: 0.96.0
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-6940) Enable GC logging by default
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-6940.
--------------------------
Resolution: Won't Fix
Fix Version/s: (was: 0.96.0)
Resolving as won't fix after reverting the patch. Will fix properly over in HBASE-6975.
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Assignee: Ted Yu
> Priority: Critical
> Attachments: 6940-trunk.txt, 6940-v2.txt, 6940-what-was-committed.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6940) Enable GC logging by default
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-6940:
--------------------------
Attachment: 6940-trunk.txt
How about this ?
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6940-trunk.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6940) Enable GC logging by default
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473877#comment-13473877 ]
stack commented on HBASE-6940:
------------------------------
Oh, just to say, sorry Ted. I should have caught how obnoxious it was going to be in the code review. My fault.
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Assignee: Ted Yu
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6940-trunk.txt, 6940-v2.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6940) Enable GC logging by default
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472849#comment-13472849 ]
Ted Yu commented on HBASE-6940:
-------------------------------
Integrated to trunk.
Thanks for the review, Stack.
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Assignee: Ted Yu
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6940-trunk.txt, 6940-v2.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6940) Enable GC logging by default
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-6940:
--------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Assignee: Ted Yu
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6940-trunk.txt, 6940-v2.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6940) Enable GC logging by default
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474055#comment-13474055 ]
Hudson commented on HBASE-6940:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #218 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/218/])
HBASE-6940 Enable GC logging by default: REVERT (Revision 1396919)
Result = SUCCESS
stack :
Files :
* /hbase/trunk/conf/hbase-env.sh
> Enable GC logging by default
> ----------------------------
>
> Key: HBASE-6940
> URL: https://issues.apache.org/jira/browse/HBASE-6940
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: stack
> Assignee: Ted Yu
> Priority: Critical
> Attachments: 6940-trunk.txt, 6940-v2.txt, 6940-what-was-committed.txt
>
>
> I think we should enable gc by default. Its pretty frictionless apparently and could help in the case where folks are getting off the ground.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira