You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "reswqa (via GitHub)" <gi...@apache.org> on 2023/04/10 18:25:06 UTC
[GitHub] [flink-connector-opensearch] reswqa opened a new pull request, #17: [hotfix] Add opensearch.yml to enable flink to find the data
reswqa opened a new pull request, #17:
URL: https://github.com/apache/flink-connector-opensearch/pull/17
I compiled the flink documentation locally and found the problem shown in the figure below:
<img width="888" alt="image" src="https://user-images.githubusercontent.com/19502505/230966931-7decad8f-c43c-4a3d-bc4f-9f8ad7efb03c.png">
It seems that we used `sql_connector_download_table` in table document but did not introduce the corresponding yml file. As a result, we get an empty artifact.
https://github.com/apache/flink/pull/22365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] dannycranmer commented on pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer commented on PR #17:
URL: https://github.com/apache/flink-connector-opensearch/pull/17#issuecomment-1505191614
ok, sounds good 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] reswqa commented on pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #17:
URL: https://github.com/apache/flink-connector-opensearch/pull/17#issuecomment-1505197306
Very thanks to @MartijnVisser and @dannycranmer for your suggestions and discussions. I have create FLINK-31779 to do this and then delete all dedicated doc branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] dannycranmer commented on pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer commented on PR #17:
URL: https://github.com/apache/flink-connector-opensearch/pull/17#issuecomment-1505153424
It makes sense to use the `v3.0` branch instead of the dedicated docs branch. Assuming we are not adding new features for patch releases otherwise the docs may show features that are not actually released. @reswqa unless I misunderstood, I do not think it is the same as what you suggested. Since when we release `v3.1.0` there will be a `v3.1` branch and we still need to update the Flink repo. I understood your proposal to remove the requirement to update the branch in the Flink repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] reswqa commented on pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #17:
URL: https://github.com/apache/flink-connector-opensearch/pull/17#issuecomment-1502153037
cc @dannycranmer. I realized we have synced the docs to flink 1.17 branch in https://github.com/apache/flink/pull/22365, to fix this, do we need to push a v1.0.0-docs branch to temporarily fix this question?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] MartijnVisser merged pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #17:
URL: https://github.com/apache/flink-connector-opensearch/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] MartijnVisser commented on pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #17:
URL: https://github.com/apache/flink-connector-opensearch/pull/17#issuecomment-1503352188
> So my main question is, if we modify a major bug in the document, do we have to wait for the next connector release so that users can see the correct version doc.
I don't think we should. I think we should update Flink to updates the references so they point to the branch, not the tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] boring-cyborg[bot] commented on pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #17:
URL: https://github.com/apache/flink-connector-opensearch/pull/17#issuecomment-1502150744
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] boring-cyborg[bot] commented on pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #17:
URL: https://github.com/apache/flink-connector-opensearch/pull/17#issuecomment-1503252794
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] reswqa commented on pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #17:
URL: https://github.com/apache/flink-connector-opensearch/pull/17#issuecomment-1503347392
I know --branch can point to both branch names and tags. If I understand correctly, we only push tags like v3.0.0 forward during each release. So my main question is, if we modify a major bug in the document, do we have to wait for the next connector release so that users can see the correct version doc. If we use v1.0.0 in setup-docs.sh, will there be this problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] MartijnVisser commented on pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #17:
URL: https://github.com/apache/flink-connector-opensearch/pull/17#issuecomment-1503249740
@reswqa We should not have specific docs branches. The release of 1.0.0 should use the docs from branch `v1.0`. That branch wasn't created until just now (which was missed somewhere), but I've just fixed that. I'll also sync your changes from `v1.0.0-docs` to `v1.0` and delete the dedicated docs branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] reswqa commented on pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #17:
URL: https://github.com/apache/flink-connector-opensearch/pull/17#issuecomment-1505176975
> unless I misunderstood, I do not think it is the same as what you suggested. Since when we release v3.1.0 there will be a v3.1 branch and we still need to update the Flink repo. I understood your proposal to remove the requirement to update the branch in the Flink repo.
Maybe I didn't fully express what I meant in our previous discuss. In my opinion, if the `v3.1` branch is created, we need to go to the flink repository to update it. 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] MartijnVisser commented on pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #17:
URL: https://github.com/apache/flink-connector-opensearch/pull/17#issuecomment-1503325434
> It seems that your proposal is that we directly track a specific branch.
You either specify a tag or a branch. You can see it in the integration function here https://github.com/apache/flink/blob/master/docs/setup_docs.sh#L29-L31
The value for Opensearch is set at https://github.com/apache/flink/blob/master/docs/setup_docs.sh#L54, which currently is `v1.0.0` which gets set as the value for `ref`, so basically the value for the parameter `--branch` when doing the git clone. The `--branch` parameter accepts both branches, as well as tags. See https://git-scm.com/docs/git-clone
```
Instead of pointing the newly created HEAD to the branch pointed to by the cloned repository’s HEAD, point to <name> branch instead. In a non-bare repository, this is the branch that will be checked out. --branch can also take tags and detaches the HEAD at that commit in the resulting repository.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] reswqa commented on pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #17:
URL: https://github.com/apache/flink-connector-opensearch/pull/17#issuecomment-1503369425
In fact, I prefer this approach, which is what I propose [here](https://issues.apache.org/jira/browse/FLINK-31704?focusedCommentId=17707954&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17707954). But let's wait for @dannycranmer's opinion again. If we can reach an agreement, I am willing to create a ticket to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] reswqa commented on pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #17:
URL: https://github.com/apache/flink-connector-opensearch/pull/17#issuecomment-1503272140
Thanks @MartijnVisser for the clarification.
One thing I am not clear about is: in the `flink` repo, should we refer to the branch of the externalized connector(e.g. v3.0) or a specific release tag (e.g. v3.0.0)? By discussion with @dannycranmer in FLINK-31704, I decided to adopt his suggestion to introduce a specific `release-tag-doc` branch to temporarily fix the documentation problem, and then delete this branch after the next release tag is generated. It seems that your proposal is that we directly track a specific branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org