You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by evmin <gi...@git.apache.org> on 2015/11/10 03:28:18 UTC

[GitHub] camel pull request: CAMEL-9224 : FIX1 - Command syntax exceptions....

GitHub user evmin opened a pull request:

    https://github.com/apache/camel/pull/672

    CAMEL-9224 : FIX1 - Command syntax exceptions. Endpoint stats filter.

    * Removed @Required CRaSH annotation to minimise unnecessary exceptions on parameter validation.
      Replaced it with a default option (where possible) - the first camel context.
      Otherwise validating required params/options with a custom method isNull()
    
    * Replaced the default option for the endpoint-stats filter - it is working now
    
    I understand the idea behind minimising the exceptions. All for it, but wanted to mention that it seems that CRaSH shell is generating one on logout.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/evmin/camel CAMEL-9224-FIX1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/672.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #672
    
----
commit 9cac2aab3dd915fb8c461fe977dbf3c56b52638d
Author: Evgeny Minkevich <ev...@gmail.com>
Date:   2015-11-10T02:14:05Z

    CAMEL-9224 : FIX1 - Removed command syntax exceptions. Fixed the default option for endpoint stats filter.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] camel pull request: CAMEL-9224 : FIX1 - Command syntax exceptions....

Posted by evmin <gi...@git.apache.org>.
Github user evmin closed the pull request at:

    https://github.com/apache/camel/pull/672


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---