You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by manbuyun <gi...@git.apache.org> on 2018/04/27 04:05:23 UTC
[GitHub] spark pull request #21176: [SPARK-24109] Remove class SnappyOutputStreamWrap...
GitHub user manbuyun opened a pull request:
https://github.com/apache/spark/pull/21176
[SPARK-24109] Remove class SnappyOutputStreamWrapper
JIRA: https://issues.apache.org/jira/browse/SPARK-24109?jql=text%20~%20%22SnappyOutputStreamWrapper%22
Wrapper over `SnappyOutputStream` which guards against write-after-close and double-close
issues. See SPARK-7660 for more details.
This wrapping can be removed if we upgrade to a version
of snappy-java that contains the fix for https://github.com/xerial/snappy-java/issues/107.
snappy-java:1.1.2+ fixed the bug
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manbuyun/spark refactor-SnappyOutputStreamWrapper
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21176
----
commit 8b93ca15bf4a5d56cd0d4c6694a7f723877a147a
Author: WangJinhai02 <ji...@...>
Date: 2018-04-27T03:40:11Z
remove SnappyOutputStreamWrapper
commit 06c8c2f60d5665da00234868b1186283e0fcd894
Author: WangJinhai02 <ji...@...>
Date: 2018-04-27T03:42:34Z
Merge branch 'master' of https://github.com/apache/spark into refactor-SnappyOutputStreamWrapper
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21176: [SPARK-24109] Remove class SnappyOutputStreamWrapper
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21176
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21176: [SPARK-24109] Remove class SnappyOutputStreamWrap...
Posted by manbuyun <gi...@git.apache.org>.
Github user manbuyun closed the pull request at:
https://github.com/apache/spark/pull/21176
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21176: [SPARK-24109] Remove class SnappyOutputStreamWrapper
Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21176
Have you checked the @srowen 's comment? https://github.com/apache/spark/pull/18949#issuecomment-323354674
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21176: [SPARK-24109] Remove class SnappyOutputStreamWrapper
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21176
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21176: [SPARK-24109] Remove class SnappyOutputStreamWrapper
Posted by manbuyun <gi...@git.apache.org>.
Github user manbuyun commented on the issue:
https://github.com/apache/spark/pull/21176
@maropu Ok. It sounds reasonable to me
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org