You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by "Brian Foster (Created) (JIRA)" <ji...@apache.org> on 2012/03/15 02:16:41 UTC
[jira] [Created] (OODT-411) Port CAS-PGE's PcsMetadataKeys to
PgeTaskMetKeys
Port CAS-PGE's PcsMetadataKeys to PgeTaskMetKeys
------------------------------------------------
Key: OODT-411
URL: https://issues.apache.org/jira/browse/OODT-411
Project: OODT
Issue Type: Sub-task
Components: pge wrapper framework
Affects Versions: 0.3
Environment: none
Reporter: Brian Foster
Assignee: Brian Foster
Priority: Minor
Fix For: 0.4
Will allow for specification of new keys while still supported legacy keys
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-411) Port CAS-PGE's PcsMetadataKeys to
PgeTaskMetKeys
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229964#comment-13229964 ]
jiraposter@reviews.apache.org commented on OODT-411:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4359/
-----------------------------------------------------------
(Updated 2012-03-15 07:47:44.274699)
Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
Changes
-------
- Organized imports and added javadoc for each Metadata key
Summary
-------
Will allow for specification of new keys while still supported legacy keys
This addresses bug OODT-411.
https://issues.apache.org/jira/browse/OODT-411
Diffs (updated)
-----
trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1300799
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java 1300799
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PcsMetadataKeys.java 1300798
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1300799
Diff: https://reviews.apache.org/r/4359/diff
Testing
-------
existing unit-tests for PgeTaskMetKeys
Thanks,
brian
> Port CAS-PGE's PcsMetadataKeys to PgeTaskMetKeys
> ------------------------------------------------
>
> Key: OODT-411
> URL: https://issues.apache.org/jira/browse/OODT-411
> Project: OODT
> Issue Type: Sub-task
> Components: pge wrapper framework
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-411.2012-03-14.patch.txt
>
>
> Will allow for specification of new keys while still supported legacy keys
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-411) Port CAS-PGE's PcsMetadataKeys to
PgeTaskMetKeys
Posted by "Brian Foster (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Foster updated OODT-411:
------------------------------
Attachment: OODT-411.2012-03-14.patch.txt
- attached patch with changes per updates at review board
> Port CAS-PGE's PcsMetadataKeys to PgeTaskMetKeys
> ------------------------------------------------
>
> Key: OODT-411
> URL: https://issues.apache.org/jira/browse/OODT-411
> Project: OODT
> Issue Type: Sub-task
> Components: pge wrapper framework
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-411.2012-03-14.patch.txt, OODT-411.2012-03-14.patch.txt
>
>
> Will allow for specification of new keys while still supported legacy keys
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-411) Port CAS-PGE's PcsMetadataKeys to
PgeTaskMetKeys
Posted by "Brian Foster (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Foster updated OODT-411:
------------------------------
Attachment: OODT-411.2012-03-14.patch.txt
- attached patch
> Port CAS-PGE's PcsMetadataKeys to PgeTaskMetKeys
> ------------------------------------------------
>
> Key: OODT-411
> URL: https://issues.apache.org/jira/browse/OODT-411
> Project: OODT
> Issue Type: Sub-task
> Components: pge wrapper framework
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-411.2012-03-14.patch.txt
>
>
> Will allow for specification of new keys while still supported legacy keys
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-411) Port CAS-PGE's PcsMetadataKeys to
PgeTaskMetKeys
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229820#comment-13229820 ]
jiraposter@reviews.apache.org commented on OODT-411:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4359/
-----------------------------------------------------------
Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
Summary
-------
Will allow for specification of new keys while still supported legacy keys
This addresses bug OODT-411.
https://issues.apache.org/jira/browse/OODT-411
Diffs
-----
trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1300799
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java 1300799
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PcsMetadataKeys.java 1300798
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1300799
Diff: https://reviews.apache.org/r/4359/diff
Testing
-------
existing unit-tests for PgeTaskMetKeys
Thanks,
brian
> Port CAS-PGE's PcsMetadataKeys to PgeTaskMetKeys
> ------------------------------------------------
>
> Key: OODT-411
> URL: https://issues.apache.org/jira/browse/OODT-411
> Project: OODT
> Issue Type: Sub-task
> Components: pge wrapper framework
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-411.2012-03-14.patch.txt
>
>
> Will allow for specification of new keys while still supported legacy keys
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OODT-411) Port CAS-PGE's PcsMetadataKeys to
PgeTaskMetKeys
Posted by "Brian Foster (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Foster resolved OODT-411.
-------------------------------
Resolution: Fixed
- fixed in r1301267
> Port CAS-PGE's PcsMetadataKeys to PgeTaskMetKeys
> ------------------------------------------------
>
> Key: OODT-411
> URL: https://issues.apache.org/jira/browse/OODT-411
> Project: OODT
> Issue Type: Sub-task
> Components: pge wrapper framework
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-411.2012-03-14.patch.txt, OODT-411.2012-03-14.patch.txt
>
>
> Will allow for specification of new keys while still supported legacy keys
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-411) Port CAS-PGE's PcsMetadataKeys to
PgeTaskMetKeys
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230336#comment-13230336 ]
jiraposter@reviews.apache.org commented on OODT-411:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4359/#review5989
-----------------------------------------------------------
Ship it!
LGTM!
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java
<https://reviews.apache.org/r/4359/#comment12984>
love the javadoc!
- Chris
On 2012-03-15 08:25:38, brian Foster wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4359/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-15 08:25:38)
bq.
bq.
bq. Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Will allow for specification of new keys while still supported legacy keys
bq.
bq.
bq. This addresses bug OODT-411.
bq. https://issues.apache.org/jira/browse/OODT-411
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1300799
bq. trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java 1300799
bq. trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PcsMetadataKeys.java 1300798
bq. trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1300799
bq. trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300799
bq. trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java 1300799
bq.
bq. Diff: https://reviews.apache.org/r/4359/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. existing unit-tests for PgeTaskMetKeys
bq.
bq.
bq. Thanks,
bq.
bq. brian
bq.
bq.
> Port CAS-PGE's PcsMetadataKeys to PgeTaskMetKeys
> ------------------------------------------------
>
> Key: OODT-411
> URL: https://issues.apache.org/jira/browse/OODT-411
> Project: OODT
> Issue Type: Sub-task
> Components: pge wrapper framework
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-411.2012-03-14.patch.txt, OODT-411.2012-03-14.patch.txt
>
>
> Will allow for specification of new keys while still supported legacy keys
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-411) Port CAS-PGE's PcsMetadataKeys to
PgeTaskMetKeys
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229984#comment-13229984 ]
jiraposter@reviews.apache.org commented on OODT-411:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4359/
-----------------------------------------------------------
(Updated 2012-03-15 08:25:38.715982)
Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
Changes
-------
Added unit-test to TestPGETaskInstance to verify Property Adders still load correctly (as well as scalar values) with new isVector() support
Summary
-------
Will allow for specification of new keys while still supported legacy keys
This addresses bug OODT-411.
https://issues.apache.org/jira/browse/OODT-411
Diffs (updated)
-----
trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1300799
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java 1300799
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PcsMetadataKeys.java 1300798
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1300799
trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300799
trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java 1300799
Diff: https://reviews.apache.org/r/4359/diff
Testing
-------
existing unit-tests for PgeTaskMetKeys
Thanks,
brian
> Port CAS-PGE's PcsMetadataKeys to PgeTaskMetKeys
> ------------------------------------------------
>
> Key: OODT-411
> URL: https://issues.apache.org/jira/browse/OODT-411
> Project: OODT
> Issue Type: Sub-task
> Components: pge wrapper framework
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-411.2012-03-14.patch.txt, OODT-411.2012-03-14.patch.txt
>
>
> Will allow for specification of new keys while still supported legacy keys
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-411) Port CAS-PGE's PcsMetadataKeys to
PgeTaskMetKeys
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229972#comment-13229972 ]
jiraposter@reviews.apache.org commented on OODT-411:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4359/
-----------------------------------------------------------
(Updated 2012-03-15 08:08:37.402954)
Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
Changes
-------
Since required only a small change, added support for isVector() to PgeTaskMetKeys which allows workflow static metadata to be split on comma if it is a multi-value type (but still allowing scalar values to contain commas without getting split into multi-values)
Summary
-------
Will allow for specification of new keys while still supported legacy keys
This addresses bug OODT-411.
https://issues.apache.org/jira/browse/OODT-411
Diffs (updated)
-----
trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1300799
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java 1300799
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PcsMetadataKeys.java 1300798
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1300799
trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java 1300799
Diff: https://reviews.apache.org/r/4359/diff
Testing
-------
existing unit-tests for PgeTaskMetKeys
Thanks,
brian
> Port CAS-PGE's PcsMetadataKeys to PgeTaskMetKeys
> ------------------------------------------------
>
> Key: OODT-411
> URL: https://issues.apache.org/jira/browse/OODT-411
> Project: OODT
> Issue Type: Sub-task
> Components: pge wrapper framework
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-411.2012-03-14.patch.txt
>
>
> Will allow for specification of new keys while still supported legacy keys
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-411) Port CAS-PGE's PcsMetadataKeys to
PgeTaskMetKeys
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231184#comment-13231184 ]
jiraposter@reviews.apache.org commented on OODT-411:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4359/#review6031
-----------------------------------------------------------
Ship it!
+1
- Paul
On 2012-03-15 08:25:38, brian Foster wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4359/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-15 08:25:38)
bq.
bq.
bq. Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Will allow for specification of new keys while still supported legacy keys
bq.
bq.
bq. This addresses bug OODT-411.
bq. https://issues.apache.org/jira/browse/OODT-411
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1300799
bq. trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java 1300799
bq. trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PcsMetadataKeys.java 1300798
bq. trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1300799
bq. trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300799
bq. trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java 1300799
bq.
bq. Diff: https://reviews.apache.org/r/4359/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. existing unit-tests for PgeTaskMetKeys
bq.
bq.
bq. Thanks,
bq.
bq. brian
bq.
bq.
> Port CAS-PGE's PcsMetadataKeys to PgeTaskMetKeys
> ------------------------------------------------
>
> Key: OODT-411
> URL: https://issues.apache.org/jira/browse/OODT-411
> Project: OODT
> Issue Type: Sub-task
> Components: pge wrapper framework
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-411.2012-03-14.patch.txt, OODT-411.2012-03-14.patch.txt
>
>
> Will allow for specification of new keys while still supported legacy keys
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira