[jira] [Commented] (PHOENIX-5641) Decouple phoenix-queryserver from phoenix-core

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000736#comment-17000736 ] 

Hadoop QA commented on PHOENIX-5641:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12989248/PHOENIX-5641.master.v1.patch
  against master branch at commit b18afb768aaa613a648e89b0af0d6e3a79f14063.
  ATTACHMENT ID: 12989248

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3211//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3211//console

This message is automatically generated.

> Decouple phoenix-queryserver from phoenix-core
> ----------------------------------------------
>
>                 Key: PHOENIX-5641
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5641
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 5.1.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>         Attachments: PHOENIX-5641.master.v1.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> phoenix-queryserver has been moved to a separate repo, and it's versioning has been decoupled from that of phoenix-core.
> Yet, phoenix-queryserver still uses code from phoenix-core, and phoenix-core in turn contains code that is only used by phoenix-queryserver.
> This causes (at least) the following problems:
>  * Adding new features to PQS is problematic, because it depends on an old released version of phoenix
>  * The phoenix-thin-client includes phoenix code, that is not really necessary
> I propose fully decoupling the PQS code from phoenix proper. This effectively means:
>  * duplicating the PQS specific configuration parameter names and defaults in PQS
>  * copying a minimal amount of code for building the JDBC connection URL
>  * copying the InstanceResolver cache class
> The tests are still dependent on phoenix-core, but I do not consider that a problem.
> If/when this patch lands in PQS, we should also remove the PQS specific parameters from phoenix-core.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)