[GitHub] [orc] dongjoon-hyun commented on a change in pull request #885: ORC-974: Remove Text Key from StringRedBlackTree

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #885:
URL: https://github.com/apache/orc/pull/885#discussion_r697784807



##########
File path: java/core/src/java/org/apache/orc/impl/RedBlackTree.java
##########
@@ -271,10 +271,14 @@ private boolean add(int node, boolean fromLeft, int parent,
 
   /**
    * Add the new key to the tree.
+   *
+   * @param bytes
+   * @param offset
+   * @param length
    * @return true if the element is a new one.
    */
-  protected boolean add() {
-    add(root, false, NULL, NULL, NULL);
+  protected boolean doAdd(byte[] bytes, int offset, int length) {

Review comment:
       Is this renamed to avoid conflicts?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org