You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2019/01/11 21:05:39 UTC
[Impala-ASF-CR] IMPALA-8071: Initial unified backend test framework
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12124
to look at the new patch set (#2).
Change subject: IMPALA-8071: Initial unified backend test framework
......................................................................
IMPALA-8071: Initial unified backend test framework
There are 100+ backend tests and each requires 400+ MB
of disk space when statically linked (the default).
This requires a large amount of disk space and adds
considerable link time.
This introduces a framework to link multiple backend
tests into a single executable. Currently it does
this for several tests in be/src/util. It saves
about 10GB of space.
It maintains several of the same properties that
the current tests have:
1. "make <testname>" rebuilds that test.
2. It generates an executable shell script with the
same name as the original backend test that runs
the same subset of tests.
3. It generates JUnitXML and log files with names that
match the test name.
4. One can run the shell script with "--gtest_filter"
and run a subset of the tests.
5. ctest commands such as ctest -R continue to function.
Introducing the framework along with a limited number
of trial backend tests gives us a chance to evaluate
this change before continuing to convert tests.
Change-Id: Ia03ef38719b1fbc0fe2025e16b7b3d3dd4488842
---
M be/CMakeLists.txt
M be/src/service/CMakeLists.txt
A be/src/service/unified-betest-main.cc
M be/src/util/CMakeLists.txt
M be/src/util/benchmark-test.cc
M be/src/util/bit-packing-test.cc
M be/src/util/bit-util-test.cc
M be/src/util/bitmap-test.cc
M be/src/util/blocking-queue-test.cc
M be/src/util/bloom-filter-test.cc
M be/src/util/coding-util-test.cc
M be/src/util/debug-util-test.cc
M be/src/util/dict-test.cc
M be/src/util/error-util-test.cc
M be/src/util/filesystem-util-test.cc
M be/src/util/fixed-size-hash-table-test.cc
M be/src/util/logging-support-test.cc
M be/src/util/lru-cache-test.cc
M be/src/util/metrics-test.cc
M be/src/util/min-max-filter-test.cc
M be/src/util/openssl-util-test.cc
M be/src/util/os-util-test.cc
M be/src/util/parse-util-test.cc
M be/src/util/pretty-printer-test.cc
M be/src/util/proc-info-test.cc
M be/src/util/rle-test.cc
M be/src/util/runtime-profile-test.cc
M be/src/util/string-parser-test.cc
M be/src/util/string-util-test.cc
M be/src/util/symbols-util-test.cc
M be/src/util/sys-info-test.cc
M be/src/util/thread-pool-test.cc
M be/src/util/time-test.cc
M be/src/util/uid-util-test.cc
M be/src/util/zip-util-test.cc
A bin/gen-backend-test-script.sh
A bin/junitxml_prune_notrun.py
A lib/python/impala_py_lib/jenkins/junitxml_prune_notrun.py
38 files changed, 307 insertions(+), 93 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/12124/2
--
To view, visit http://gerrit.cloudera.org:8080/12124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia03ef38719b1fbc0fe2025e16b7b3d3dd4488842
Gerrit-Change-Number: 12124
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>