You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/14 15:28:19 UTC
[GitHub] [beam] aromanenko-dev opened a new pull request, #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
aromanenko-dev opened a new pull request, #17372:
URL: https://github.com/apache/beam/pull/17372
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a diff in pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on code in PR #17372:
URL: https://github.com/apache/beam/pull/17372#discussion_r851203715
##########
sdks/java/core/build.gradle:
##########
@@ -105,5 +105,6 @@ dependencies {
shadowTest library.java.avro_tests
shadowTest library.java.zstd_jni
shadowTest library.java.jamm
+ shadowTest library.java.xz_java
Review Comment:
Because starting from Avro 1.9.0 this dependency became `provided` but we need this for tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a diff in pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on code in PR #17372:
URL: https://github.com/apache/beam/pull/17372#discussion_r851394420
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java:
##########
@@ -128,6 +129,14 @@ private <T> T getValue(FieldType type, Object fieldValue, @Nullable Integer cach
cachedMaps.computeIfAbsent(
cacheKey, i -> getMapValue(type.getMapKeyType(), type.getMapValueType(), map))
: (T) getMapValue(type.getMapKeyType(), type.getMapValueType(), map);
+ } else if (type.getTypeName().equals(TypeName.DATETIME)) {
+ if (fieldValue instanceof java.time.LocalDate) {
+ Instant instant = java.time.Instant.parse(fieldValue + "T00:00:00.00Z");
+ return (T) org.joda.time.Instant.ofEpochMilli(instant.toEpochMilli());
+ } else if (fieldValue instanceof java.time.Instant) {
+ return (T) org.joda.time.Instant.ofEpochMilli(((Instant) fieldValue).toEpochMilli());
+ }
+ return (T) fieldValue;
Review Comment:
I'm not sure it's related to only Avro case but since Beam schema uses joda time internally then java time should be converted in any case until we won't switch to java time (if we will, of course).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17372:
URL: https://github.com/apache/beam/pull/17372#issuecomment-1130162041
I close this one since, based on [email discussion](https://lists.apache.org/thread/mz8hvz8dwhd0tzmv2lyobhlz7gtg4gq7), we won't follow this way in terms of Avro version update. Though, still useful to have these changes somewhere that are needed to do in Beam to support more recent Avro versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17372:
URL: https://github.com/apache/beam/pull/17372#issuecomment-1106882368
Run SQL PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev closed pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev closed pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
URL: https://github.com/apache/beam/pull/17372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17372:
URL: https://github.com/apache/beam/pull/17372#issuecomment-1107419091
@TheNeuralBit Yes, good point. I'm going to start a thread on this topic on mailing list once I'll be back from vacation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17372:
URL: https://github.com/apache/beam/pull/17372#issuecomment-1106882658
Run Java PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17372:
URL: https://github.com/apache/beam/pull/17372#issuecomment-1099341426
R: @TheNeuralBit
R: @reuvenlax
I tried to upgrade gracefully Avro dependency to the next major version 1.9.2 (the main reason, finally, is to move to Avro 1.11,0 to avoid having CVEs that Avro brings). Could you take a brief look? Does it make sense for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17372:
URL: https://github.com/apache/beam/pull/17372#issuecomment-1102749606
Run Spark StructuredStreaming ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on a diff in pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
mosche commented on code in PR #17372:
URL: https://github.com/apache/beam/pull/17372#discussion_r856132501
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java:
##########
@@ -128,6 +129,14 @@ private <T> T getValue(FieldType type, Object fieldValue, @Nullable Integer cach
cachedMaps.computeIfAbsent(
cacheKey, i -> getMapValue(type.getMapKeyType(), type.getMapValueType(), map))
: (T) getMapValue(type.getMapKeyType(), type.getMapValueType(), map);
+ } else if (type.getTypeName().equals(TypeName.DATETIME)) {
+ if (fieldValue instanceof java.time.LocalDate) {
+ Instant instant = java.time.Instant.parse(fieldValue + "T00:00:00.00Z");
+ return (T) org.joda.time.Instant.ofEpochMilli(instant.toEpochMilli());
+ } else if (fieldValue instanceof java.time.Instant) {
+ return (T) org.joda.time.Instant.ofEpochMilli(((Instant) fieldValue).toEpochMilli());
+ }
+ return (T) fieldValue;
Review Comment:
@aromanenko-dev I think @TheNeuralBit is right. Based on [benchmarks](https://github.com/apache/beam/pull/17172#issuecomment-1085981280) I've done just recently, branching in `RowWithGetters` doesn't perform well. In https://github.com/apache/beam/pull/17172 I'm suggesting to push all of the current code down into the getters.
The `GetterBasedSchemaProvider`s (except the Avro one) only support Joda [ReadableInstant](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/StaticSchemaInference.java#L144-L145) (type is the method return type or field type) as `DATETIME`. Attempting to use java time would most likely fail during schema generation ([or generate a row schema with nested internal fields](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/StaticSchemaInference.java#L166))
For Avro there's already a [conversion layer](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java#L278-L294) in place you could leverage for that. For `DATETIME` it's using these converters:
- [ConvertValueForGetter.convertDateTime](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/ByteBuddyUtils.java#L792)
- [ConvertValueForSetter.convertDateTime](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/ByteBuddyUtils.java#L1160)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a diff in pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on code in PR #17372:
URL: https://github.com/apache/beam/pull/17372#discussion_r851395559
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/GcpApiSurfaceTest.java:
##########
@@ -121,7 +121,6 @@ public void testGcpApiSurface() throws Exception {
classesInPackage("org.apache.avro"),
classesInPackage("org.apache.beam"),
classesInPackage("org.apache.commons.logging"),
- classesInPackage("org.codehaus.jackson"),
Review Comment:
This is not an Avro's dependency anymore .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17372:
URL: https://github.com/apache/beam/pull/17372#issuecomment-1100261894
@TheNeuralBit Thanks for taking a look!
Unfortunately, Avro introduced some breaking changes so I'm not sure that we can do something with that if we want to move forward with Avro version bump. Another option, potentially, would be to make it as `provided` deps but I'm not sure we can allow to do that (IIRC, #16271 also introduced some breaking changes for Beam users).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17372:
URL: https://github.com/apache/beam/pull/17372#issuecomment-1099344007
CC:
R: @iemejia
R: @RyanSkraba
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a diff in pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on code in PR #17372:
URL: https://github.com/apache/beam/pull/17372#discussion_r851395559
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/GcpApiSurfaceTest.java:
##########
@@ -121,7 +121,6 @@ public void testGcpApiSurface() throws Exception {
classesInPackage("org.apache.avro"),
classesInPackage("org.apache.beam"),
classesInPackage("org.apache.commons.logging"),
- classesInPackage("org.codehaus.jackson"),
Review Comment:
This is not a Avro's dependency anymore .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17372:
URL: https://github.com/apache/beam/pull/17372#issuecomment-1106882798
Run Spark ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17372:
URL: https://github.com/apache/beam/pull/17372#issuecomment-1106882558
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17372:
URL: https://github.com/apache/beam/pull/17372#issuecomment-1099342126
Run Java PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a diff in pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on code in PR #17372:
URL: https://github.com/apache/beam/pull/17372#discussion_r850621495
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java:
##########
@@ -128,6 +129,14 @@ private <T> T getValue(FieldType type, Object fieldValue, @Nullable Integer cach
cachedMaps.computeIfAbsent(
cacheKey, i -> getMapValue(type.getMapKeyType(), type.getMapValueType(), map))
: (T) getMapValue(type.getMapKeyType(), type.getMapValueType(), map);
+ } else if (type.getTypeName().equals(TypeName.DATETIME)) {
+ if (fieldValue instanceof java.time.LocalDate) {
+ Instant instant = java.time.Instant.parse(fieldValue + "T00:00:00.00Z");
+ return (T) org.joda.time.Instant.ofEpochMilli(instant.toEpochMilli());
+ } else if (fieldValue instanceof java.time.Instant) {
+ return (T) org.joda.time.Instant.ofEpochMilli(((Instant) fieldValue).toEpochMilli());
+ }
+ return (T) fieldValue;
Review Comment:
I think this logic should be in the Avro getters, instead of branching on this instance check.
##########
sdks/java/core/build.gradle:
##########
@@ -105,5 +105,6 @@ dependencies {
shadowTest library.java.avro_tests
shadowTest library.java.zstd_jni
shadowTest library.java.jamm
+ shadowTest library.java.xz_java
Review Comment:
Why do we need to add this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #17372:
URL: https://github.com/apache/beam/pull/17372#issuecomment-1099329981
# [Codecov](https://codecov.io/gh/apache/beam/pull/17372?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17372](https://codecov.io/gh/apache/beam/pull/17372?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ffe0881) into [master](https://codecov.io/gh/apache/beam/commit/2aa24dc3758750bd76c024dc787c06b91fd725ed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2aa24dc) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #17372 +/- ##
=======================================
Coverage 73.99% 73.99%
=======================================
Files 685 685
Lines 89727 89727
=======================================
Hits 66395 66395
Misses 22172 22172
Partials 1160 1160
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/17372?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/17372?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2aa24dc...ffe0881](https://codecov.io/gh/apache/beam/pull/17372?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17372:
URL: https://github.com/apache/beam/pull/17372#issuecomment-1102749832
Run Python Spark ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17372:
URL: https://github.com/apache/beam/pull/17372#issuecomment-1102748997
Run Spark ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #17372: [WIP][BEAM-8715] Bump Avro version to 1.9.2
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #17372:
URL: https://github.com/apache/beam/pull/17372#issuecomment-1106903955
> Unfortunately, Avro introduced some breaking changes so I'm not sure that we can do something with that if we want to move forward with Avro version bump.
Fair point - I guess it's ok if we communicate it clearly to users. Should we raise this on the dev list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org