You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Tamás Cservenák <ta...@cservenak.net> on 2012/08/07 23:20:57 UTC
Maven Indexer Changes
Hi there,
Olivier did a great job of releasing Maven Indexer 4.1.3 that bumped Lucene
to 3.6.1.
But, having Lucene 3.6.1 in MI makes us now possible to do more. Here is a
branch I did today:
https://github.com/cstamas/maven-indexer/commits/fixes
Basically, it has following changes:
* Removed heavy uses of StringBuffer, replaced with StringBuilder
* Version bumped to 4.5.0-SNAP (from 4.1.4-SNAP) as changes below
introduces API breakage (especially how you "acquire" IndexSearcher from
context, needed to properly implement locking semantics)
* Removed bottle warmer threads completely
* Removed problematic locking around contexts as we rely now on Lucene
* Using new SearcherManager (see
http://blog.mikemccandless.com/2011/09/lucenes-searchermanager-simplifies.html)
instead of doing all this manually + relying on those removed stuff above
* Removed deprecated baggage
Changes above renders issues MINDEXER-52 and alike actually a "non-issues".
Please comment the changes.
Thanks,
~t~
Re: Maven Indexer Changes
Posted by Tamás Cservenák <ta...@cservenak.net>.
It's something not needed when you are breastfeeding :p
Thanks,
~t~ mobile
On Aug 8, 2012 8:07 AM, "Kristian Rosenvold" <kr...@gmail.com>
wrote:
> Exactly what is a "Bottle warmer thread" ?? I think I want one too ;)
>
> Kristian
>
>
> 2012/8/7 Tamás Cservenák <ta...@cservenak.net>:
> > Hi there,
> >
> > Olivier did a great job of releasing Maven Indexer 4.1.3 that bumped
> Lucene
> > to 3.6.1.
> >
> > But, having Lucene 3.6.1 in MI makes us now possible to do more. Here is
> a
> > branch I did today:
> > https://github.com/cstamas/maven-indexer/commits/fixes
> >
> > Basically, it has following changes:
> > * Removed heavy uses of StringBuffer, replaced with StringBuilder
> > * Version bumped to 4.5.0-SNAP (from 4.1.4-SNAP) as changes below
> > introduces API breakage (especially how you "acquire" IndexSearcher from
> > context, needed to properly implement locking semantics)
> > * Removed bottle warmer threads completely
> > * Removed problematic locking around contexts as we rely now on Lucene
> > * Using new SearcherManager (see
> >
> http://blog.mikemccandless.com/2011/09/lucenes-searchermanager-simplifies.html
> )
> > instead of doing all this manually + relying on those removed stuff above
> > * Removed deprecated baggage
> >
> > Changes above renders issues MINDEXER-52 and alike actually a
> "non-issues".
> >
> >
> > Please comment the changes.
> >
> >
> >
> > Thanks,
> > ~t~
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: Maven Indexer Changes
Posted by Kristian Rosenvold <kr...@gmail.com>.
Exactly what is a "Bottle warmer thread" ?? I think I want one too ;)
Kristian
2012/8/7 Tamás Cservenák <ta...@cservenak.net>:
> Hi there,
>
> Olivier did a great job of releasing Maven Indexer 4.1.3 that bumped Lucene
> to 3.6.1.
>
> But, having Lucene 3.6.1 in MI makes us now possible to do more. Here is a
> branch I did today:
> https://github.com/cstamas/maven-indexer/commits/fixes
>
> Basically, it has following changes:
> * Removed heavy uses of StringBuffer, replaced with StringBuilder
> * Version bumped to 4.5.0-SNAP (from 4.1.4-SNAP) as changes below
> introduces API breakage (especially how you "acquire" IndexSearcher from
> context, needed to properly implement locking semantics)
> * Removed bottle warmer threads completely
> * Removed problematic locking around contexts as we rely now on Lucene
> * Using new SearcherManager (see
> http://blog.mikemccandless.com/2011/09/lucenes-searchermanager-simplifies.html)
> instead of doing all this manually + relying on those removed stuff above
> * Removed deprecated baggage
>
> Changes above renders issues MINDEXER-52 and alike actually a "non-issues".
>
>
> Please comment the changes.
>
>
>
> Thanks,
> ~t~
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven Indexer Changes
Posted by Mark Derricutt <ma...@talios.com>.
For what its worth, Java 6's EOL just got pushed out till Feb 2013:
https://blogs.oracle.com/henrik/entry/java_6_eol_h_h
Mark
On 9/08/2012, at 7:43 AM, Tamás Cservenák wrote:
> In short: Java6 EOL is coming in months now, users running 1.5 and below
> should really consider an upgrade.
Re: Maven Indexer Changes
Posted by Olivier Lamy <ol...@apache.org>.
Perso, in 2012 I don't see any issue being 1.6 required.
Especially for a component which is not used in core neither in any plugin.
2012/8/8 Robert Scholte <rf...@apache.org>:
> In theory you're right about the timing, but the facts are different. It
> seems like the larger the company, the slower the time. I've seen companies
> still using jdk1.4 because they had a lot of trouble to upgrade to a newer
> version of an application server.
> The version of this JDK is not related to the version used by Maven,
> although some think they should use the same JDK.
>
> JDK5's EOL was april 2008, I'm pretty sure Maven started requiring JDK5 a
> lot of months (years?) after this date.
>
> Some time we should move to JDK6, but I don't think that time has come yet.
>
> Robert
>
> Op Wed, 08 Aug 2012 21:43:24 +0200 schreef Tamás Cservenák
> <ta...@cservenak.net>:
>
>
>> In short: Java6 EOL is coming in months now, users running 1.5 and below
>> should really consider an upgrade.
>> A bit longer: Java6 1st release happened in 2006, 6 years ago. In our
>> profession, that is around 70 years old, 6 years corresponds to -- for
>> example in optics (first known lenses are about 700 BC according to
>> wikipedia) -- to roughly 233 years. So, in case you wear spectacles, would
>> you wear these today http://www.sptddog.com/sotp/18thcent.jpg ?
>>
>>
>> In essence: not really needed for now, as Lucene 3.6.1 is fine on Java5,
>> and IOEx new constructor is used in very few places.... but we can go back
>> in time for 233 years for now.
>>
>>
>> Thanks,
>> ~t~
>>
>> On Wed, Aug 8, 2012 at 7:24 PM, Robert Scholte <rf...@apache.org>
>> wrote:
>>
>>> What's the reason for the "Bumped MI to Java6 level."?
>>> Looks like a potential issue to me (assuming a lot of projects still use
>>> java5)
>>>
>>> -Robert
>>>
>>> Op Wed, 08 Aug 2012 18:29:41 +0200 schreef Olivier Lamy <olamy@apache.org
>>> >:
>>>
>>>
>>> Nice changes.
>>>>
>>>> +1 to merge that.
>>>> Maybe some jiras entries to create :-)
>>>>
>>>> --
>>>> Olivier
>>>> Le 7 août 2012 23:21, "Tamás Cservenák" <ta...@cservenak.net> a écrit :
>>>>
>>>> Hi there,
>>>>>
>>>>>
>>>>> Olivier did a great job of releasing Maven Indexer 4.1.3 that bumped
>>>>> Lucene
>>>>> to 3.6.1.
>>>>>
>>>>> But, having Lucene 3.6.1 in MI makes us now possible to do more. Here
>>>>> is
>>>>> a
>>>>> branch I did today:
>>>>>
>>>>> https://github.com/cstamas/**maven-indexer/commits/fixes<https://github.com/cstamas/maven-indexer/commits/fixes>
>>>>>
>>>>> Basically, it has following changes:
>>>>> * Removed heavy uses of StringBuffer, replaced with StringBuilder
>>>>> * Version bumped to 4.5.0-SNAP (from 4.1.4-SNAP) as changes below
>>>>> introduces API breakage (especially how you "acquire" IndexSearcher
>>>>> from
>>>>> context, needed to properly implement locking semantics)
>>>>> * Removed bottle warmer threads completely
>>>>> * Removed problematic locking around contexts as we rely now on Lucene
>>>>> * Using new SearcherManager (see
>>>>>
>>>>> http://blog.mikemccandless.**com/2011/09/lucenes-**
>>>>>
>>>>> searchermanager-simplifies.**html<http://blog.mikemccandless.com/2011/09/lucenes-searchermanager-simplifies.html>
>>>>> )
>>>>> instead of doing all this manually + relying on those removed stuff
>>>>> above
>>>>> * Removed deprecated baggage
>>>>>
>>>>> Changes above renders issues MINDEXER-52 and alike actually a
>>>>> "non-issues".
>>>>>
>>>>>
>>>>> Please comment the changes.
>>>>>
>>>>>
>>>>>
>>>>> Thanks,
>>>>> ~t~
>>>>>
>>>>
>>> ------------------------------**------------------------------**---------
>>> To unsubscribe, e-mail:
>>> dev-unsubscribe@maven.apache.**org<de...@maven.apache.org>
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven Indexer Changes
Posted by Markku Saarela <ma...@pp6.inet.fi>.
HI,
JDK6's EOL is Feb 2013
(http://www.oracle.com/technetwork/java/eol-135779.html), so it's near.
Markku
On 8.8.2012 23:46, Robert Scholte wrote:
> In theory you're right about the timing, but the facts are different.
> It seems like the larger the company, the slower the time. I've seen
> companies still using jdk1.4 because they had a lot of trouble to
> upgrade to a newer version of an application server.
> The version of this JDK is not related to the version used by Maven,
> although some think they should use the same JDK.
>
> JDK5's EOL was april 2008, I'm pretty sure Maven started requiring
> JDK5 a lot of months (years?) after this date.
>
> Some time we should move to JDK6, but I don't think that time has come
> yet.
>
> Robert
>
> Op Wed, 08 Aug 2012 21:43:24 +0200 schreef Tamás Cservenák
> <ta...@cservenak.net>:
>
>> In short: Java6 EOL is coming in months now, users running 1.5 and below
>> should really consider an upgrade.
>> A bit longer: Java6 1st release happened in 2006, 6 years ago. In our
>> profession, that is around 70 years old, 6 years corresponds to -- for
>> example in optics (first known lenses are about 700 BC according to
>> wikipedia) -- to roughly 233 years. So, in case you wear spectacles,
>> would
>> you wear these today http://www.sptddog.com/sotp/18thcent.jpg ?
>>
>>
>> In essence: not really needed for now, as Lucene 3.6.1 is fine on Java5,
>> and IOEx new constructor is used in very few places.... but we can go
>> back
>> in time for 233 years for now.
>>
>>
>> Thanks,
>> ~t~
>>
>> On Wed, Aug 8, 2012 at 7:24 PM, Robert Scholte <rf...@apache.org>
>> wrote:
>>
>>> What's the reason for the "Bumped MI to Java6 level."?
>>> Looks like a potential issue to me (assuming a lot of projects still
>>> use
>>> java5)
>>>
>>> -Robert
>>>
>>> Op Wed, 08 Aug 2012 18:29:41 +0200 schreef Olivier Lamy
>>> <olamy@apache.org
>>> >:
>>>
>>>
>>> Nice changes.
>>>> +1 to merge that.
>>>> Maybe some jiras entries to create :-)
>>>>
>>>> --
>>>> Olivier
>>>> Le 7 août 2012 23:21, "Tamás Cservenák" <ta...@cservenak.net> a
>>>> écrit :
>>>>
>>>> Hi there,
>>>>>
>>>>> Olivier did a great job of releasing Maven Indexer 4.1.3 that bumped
>>>>> Lucene
>>>>> to 3.6.1.
>>>>>
>>>>> But, having Lucene 3.6.1 in MI makes us now possible to do more.
>>>>> Here is
>>>>> a
>>>>> branch I did today:
>>>>> https://github.com/cstamas/**maven-indexer/commits/fixes<https://github.com/cstamas/maven-indexer/commits/fixes>
>>>>>
>>>>>
>>>>> Basically, it has following changes:
>>>>> * Removed heavy uses of StringBuffer, replaced with StringBuilder
>>>>> * Version bumped to 4.5.0-SNAP (from 4.1.4-SNAP) as changes below
>>>>> introduces API breakage (especially how you "acquire"
>>>>> IndexSearcher from
>>>>> context, needed to properly implement locking semantics)
>>>>> * Removed bottle warmer threads completely
>>>>> * Removed problematic locking around contexts as we rely now on
>>>>> Lucene
>>>>> * Using new SearcherManager (see
>>>>>
>>>>> http://blog.mikemccandless.**com/2011/09/lucenes-**
>>>>> searchermanager-simplifies.**html<http://blog.mikemccandless.com/2011/09/lucenes-searchermanager-simplifies.html>
>>>>>
>>>>> )
>>>>> instead of doing all this manually + relying on those removed
>>>>> stuff above
>>>>> * Removed deprecated baggage
>>>>>
>>>>> Changes above renders issues MINDEXER-52 and alike actually a
>>>>> "non-issues".
>>>>>
>>>>>
>>>>> Please comment the changes.
>>>>>
>>>>>
>>>>>
>>>>> Thanks,
>>>>> ~t~
>>>>>
>>>>
>>> ------------------------------**------------------------------**---------
>>>
>>> To unsubscribe, e-mail:
>>> dev-unsubscribe@maven.apache.**org<de...@maven.apache.org>
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven Indexer Changes
Posted by Robert Scholte <rf...@apache.org>.
In theory you're right about the timing, but the facts are different. It
seems like the larger the company, the slower the time. I've seen
companies still using jdk1.4 because they had a lot of trouble to upgrade
to a newer version of an application server.
The version of this JDK is not related to the version used by Maven,
although some think they should use the same JDK.
JDK5's EOL was april 2008, I'm pretty sure Maven started requiring JDK5 a
lot of months (years?) after this date.
Some time we should move to JDK6, but I don't think that time has come yet.
Robert
Op Wed, 08 Aug 2012 21:43:24 +0200 schreef Tamás Cservenák
<ta...@cservenak.net>:
> In short: Java6 EOL is coming in months now, users running 1.5 and below
> should really consider an upgrade.
> A bit longer: Java6 1st release happened in 2006, 6 years ago. In our
> profession, that is around 70 years old, 6 years corresponds to -- for
> example in optics (first known lenses are about 700 BC according to
> wikipedia) -- to roughly 233 years. So, in case you wear spectacles,
> would
> you wear these today http://www.sptddog.com/sotp/18thcent.jpg ?
>
>
> In essence: not really needed for now, as Lucene 3.6.1 is fine on Java5,
> and IOEx new constructor is used in very few places.... but we can go
> back
> in time for 233 years for now.
>
>
> Thanks,
> ~t~
>
> On Wed, Aug 8, 2012 at 7:24 PM, Robert Scholte <rf...@apache.org>
> wrote:
>
>> What's the reason for the "Bumped MI to Java6 level."?
>> Looks like a potential issue to me (assuming a lot of projects still use
>> java5)
>>
>> -Robert
>>
>> Op Wed, 08 Aug 2012 18:29:41 +0200 schreef Olivier Lamy
>> <olamy@apache.org
>> >:
>>
>>
>> Nice changes.
>>> +1 to merge that.
>>> Maybe some jiras entries to create :-)
>>>
>>> --
>>> Olivier
>>> Le 7 août 2012 23:21, "Tamás Cservenák" <ta...@cservenak.net> a écrit :
>>>
>>> Hi there,
>>>>
>>>> Olivier did a great job of releasing Maven Indexer 4.1.3 that bumped
>>>> Lucene
>>>> to 3.6.1.
>>>>
>>>> But, having Lucene 3.6.1 in MI makes us now possible to do more. Here
>>>> is
>>>> a
>>>> branch I did today:
>>>> https://github.com/cstamas/**maven-indexer/commits/fixes<https://github.com/cstamas/maven-indexer/commits/fixes>
>>>>
>>>> Basically, it has following changes:
>>>> * Removed heavy uses of StringBuffer, replaced with StringBuilder
>>>> * Version bumped to 4.5.0-SNAP (from 4.1.4-SNAP) as changes below
>>>> introduces API breakage (especially how you "acquire" IndexSearcher
>>>> from
>>>> context, needed to properly implement locking semantics)
>>>> * Removed bottle warmer threads completely
>>>> * Removed problematic locking around contexts as we rely now on Lucene
>>>> * Using new SearcherManager (see
>>>>
>>>> http://blog.mikemccandless.**com/2011/09/lucenes-**
>>>> searchermanager-simplifies.**html<http://blog.mikemccandless.com/2011/09/lucenes-searchermanager-simplifies.html>
>>>> )
>>>> instead of doing all this manually + relying on those removed stuff
>>>> above
>>>> * Removed deprecated baggage
>>>>
>>>> Changes above renders issues MINDEXER-52 and alike actually a
>>>> "non-issues".
>>>>
>>>>
>>>> Please comment the changes.
>>>>
>>>>
>>>>
>>>> Thanks,
>>>> ~t~
>>>>
>>>
>> ------------------------------**------------------------------**---------
>> To unsubscribe, e-mail:
>> dev-unsubscribe@maven.apache.**org<de...@maven.apache.org>
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven Indexer Changes
Posted by Tamás Cservenák <ta...@cservenak.net>.
Ok. As I said, java6 is not a must. Will be undone and merge prepared.
Thanks,
~t~ mobile
On Aug 9, 2012 4:14 AM, "Chris Graham" <ch...@gmail.com> wrote:
> Whilst Java6 may be soon coming to EOL, I am still supporting many large
> corporates on Java 1.4 - corporates do not necessarily move quickly - not
> if their solution works.
>
> Just something to consider from the real world.
>
> -Chris
>
> Sent from my iPhone
>
> On 09/08/2012, at 1:13 AM, Tamás Cservenák <ta...@cservenak.net> wrote:
>
> > In short: Java6 EOL is coming in months now, users running 1.5 and below
> > should really consider an upgrade.
> > A bit longer: Java6 1st release happened in 2006, 6 years ago. In our
> > profession, that is around 70 years old, 6 years corresponds to -- for
> > example in optics (first known lenses are about 700 BC according to
> > wikipedia) -- to roughly 233 years. So, in case you wear spectacles,
> would
> > you wear these today http://www.sptddog.com/sotp/18thcent.jpg ?
> >
> >
> > In essence: not really needed for now, as Lucene 3.6.1 is fine on Java5,
> > and IOEx new constructor is used in very few places.... but we can go
> back
> > in time for 233 years for now.
> >
> >
> > Thanks,
> > ~t~
> >
> > On Wed, Aug 8, 2012 at 7:24 PM, Robert Scholte <rf...@apache.org>
> wrote:
> >
> >> What's the reason for the "Bumped MI to Java6 level."?
> >> Looks like a potential issue to me (assuming a lot of projects still use
> >> java5)
> >>
> >> -Robert
> >>
> >> Op Wed, 08 Aug 2012 18:29:41 +0200 schreef Olivier Lamy <
> olamy@apache.org
> >>> :
> >>
> >>
> >> Nice changes.
> >>> +1 to merge that.
> >>> Maybe some jiras entries to create :-)
> >>>
> >>> --
> >>> Olivier
> >>> Le 7 août 2012 23:21, "Tamás Cservenák" <ta...@cservenak.net> a écrit
> :
> >>>
> >>> Hi there,
> >>>>
> >>>> Olivier did a great job of releasing Maven Indexer 4.1.3 that bumped
> >>>> Lucene
> >>>> to 3.6.1.
> >>>>
> >>>> But, having Lucene 3.6.1 in MI makes us now possible to do more. Here
> is
> >>>> a
> >>>> branch I did today:
> >>>> https://github.com/cstamas/**maven-indexer/commits/fixes<
> https://github.com/cstamas/maven-indexer/commits/fixes>
> >>>>
> >>>> Basically, it has following changes:
> >>>> * Removed heavy uses of StringBuffer, replaced with StringBuilder
> >>>> * Version bumped to 4.5.0-SNAP (from 4.1.4-SNAP) as changes below
> >>>> introduces API breakage (especially how you "acquire" IndexSearcher
> from
> >>>> context, needed to properly implement locking semantics)
> >>>> * Removed bottle warmer threads completely
> >>>> * Removed problematic locking around contexts as we rely now on Lucene
> >>>> * Using new SearcherManager (see
> >>>>
> >>>> http://blog.mikemccandless.**com/2011/09/lucenes-**
> >>>> searchermanager-simplifies.**html<
> http://blog.mikemccandless.com/2011/09/lucenes-searchermanager-simplifies.html
> >
> >>>> )
> >>>> instead of doing all this manually + relying on those removed stuff
> above
> >>>> * Removed deprecated baggage
> >>>>
> >>>> Changes above renders issues MINDEXER-52 and alike actually a
> >>>> "non-issues".
> >>>>
> >>>>
> >>>> Please comment the changes.
> >>>>
> >>>>
> >>>>
> >>>> Thanks,
> >>>> ~t~
> >>>>
> >>>
> >>
> ------------------------------**------------------------------**---------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.**org<
> dev-unsubscribe@maven.apache.org>
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: Maven Indexer Changes
Posted by Chris Graham <ch...@gmail.com>.
Whilst Java6 may be soon coming to EOL, I am still supporting many large corporates on Java 1.4 - corporates do not necessarily move quickly - not if their solution works.
Just something to consider from the real world.
-Chris
Sent from my iPhone
On 09/08/2012, at 1:13 AM, Tamás Cservenák <ta...@cservenak.net> wrote:
> In short: Java6 EOL is coming in months now, users running 1.5 and below
> should really consider an upgrade.
> A bit longer: Java6 1st release happened in 2006, 6 years ago. In our
> profession, that is around 70 years old, 6 years corresponds to -- for
> example in optics (first known lenses are about 700 BC according to
> wikipedia) -- to roughly 233 years. So, in case you wear spectacles, would
> you wear these today http://www.sptddog.com/sotp/18thcent.jpg ?
>
>
> In essence: not really needed for now, as Lucene 3.6.1 is fine on Java5,
> and IOEx new constructor is used in very few places.... but we can go back
> in time for 233 years for now.
>
>
> Thanks,
> ~t~
>
> On Wed, Aug 8, 2012 at 7:24 PM, Robert Scholte <rf...@apache.org> wrote:
>
>> What's the reason for the "Bumped MI to Java6 level."?
>> Looks like a potential issue to me (assuming a lot of projects still use
>> java5)
>>
>> -Robert
>>
>> Op Wed, 08 Aug 2012 18:29:41 +0200 schreef Olivier Lamy <olamy@apache.org
>>> :
>>
>>
>> Nice changes.
>>> +1 to merge that.
>>> Maybe some jiras entries to create :-)
>>>
>>> --
>>> Olivier
>>> Le 7 août 2012 23:21, "Tamás Cservenák" <ta...@cservenak.net> a écrit :
>>>
>>> Hi there,
>>>>
>>>> Olivier did a great job of releasing Maven Indexer 4.1.3 that bumped
>>>> Lucene
>>>> to 3.6.1.
>>>>
>>>> But, having Lucene 3.6.1 in MI makes us now possible to do more. Here is
>>>> a
>>>> branch I did today:
>>>> https://github.com/cstamas/**maven-indexer/commits/fixes<https://github.com/cstamas/maven-indexer/commits/fixes>
>>>>
>>>> Basically, it has following changes:
>>>> * Removed heavy uses of StringBuffer, replaced with StringBuilder
>>>> * Version bumped to 4.5.0-SNAP (from 4.1.4-SNAP) as changes below
>>>> introduces API breakage (especially how you "acquire" IndexSearcher from
>>>> context, needed to properly implement locking semantics)
>>>> * Removed bottle warmer threads completely
>>>> * Removed problematic locking around contexts as we rely now on Lucene
>>>> * Using new SearcherManager (see
>>>>
>>>> http://blog.mikemccandless.**com/2011/09/lucenes-**
>>>> searchermanager-simplifies.**html<http://blog.mikemccandless.com/2011/09/lucenes-searchermanager-simplifies.html>
>>>> )
>>>> instead of doing all this manually + relying on those removed stuff above
>>>> * Removed deprecated baggage
>>>>
>>>> Changes above renders issues MINDEXER-52 and alike actually a
>>>> "non-issues".
>>>>
>>>>
>>>> Please comment the changes.
>>>>
>>>>
>>>>
>>>> Thanks,
>>>> ~t~
>>>>
>>>
>> ------------------------------**------------------------------**---------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.**org<de...@maven.apache.org>
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven Indexer Changes
Posted by Milos Kleint <mk...@gmail.com>.
On Thu, Aug 9, 2012 at 2:33 AM, Brett Porter <br...@apache.org> wrote:
>
> On 09/08/2012, at 5:43 AM, Tamás Cservenák <ta...@cservenak.net> wrote:
>
>
>> In essence: not really needed for now, as Lucene 3.6.1 is fine on Java5,
>> and IOEx new constructor is used in very few places.... but we can go back
>> in time for 233 years for now.
>
> I don't have a problem with updating it if there's something useful to take advantage of, knowing the user-base of the library. In other libraries, we don't need to upgrade just for the sake of it, of course.
>
netbeans is using the indexer extensively, already on 1.6 for some time.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven Indexer Changes
Posted by Tamás Cservenák <ta...@cservenak.net>.
Brett and others,
I rolled back MI to Java5, but I agree, due to API breakage I did bump the
version to 5.0.0-SNAPSHOT.
https://github.com/cstamas/maven-indexer/commits/fixes
As for "consumer" side code, few examples:
Maven Indexer Examples updated to represent needed changes (commented on
API changes for clarity sake, but I had some reformats happening too, sorry
for that):
https://github.com/cstamas/maven-indexer-examples/commit/eb38e442889d072d380c8fb18e5f35a5dd372076
Other example might be Nexus itself, here is a branch (from yesterday,
where MI version is still 4.5.0-SNAP but API is already the same as in
5.0.0-SNAP):
https://github.com/sonatype/nexus/commit/e8301d4cf93b7dba5d10988124696262b1786433
As you see, the "API breakage" actually depends very much on how you use
MI, as for example Nexus code _had no changes_ (only one UT doing low-level
stuff to bring index into some specific state). If you did not tamper with
"low level" access of it by using IndexSearcher directly, you might be
lucky and need no change at all :)
Thanks,
~t~
On Thu, Aug 9, 2012 at 2:33 AM, Brett Porter <br...@apache.org> wrote:
> I don't have a problem with updating it if there's something useful to
> take advantage of, knowing the user-base of the library. In other
> libraries, we don't need to upgrade just for the sake of it, of course.
>
> Perhaps with this requirement, and the API breakage you indicated, the
> version could bump to 5.0.0-SNAPSHOT? I like the semantic versioning rules (
> semver.org).
>
>
Re: Maven Indexer Changes
Posted by Brett Porter <br...@apache.org>.
On 09/08/2012, at 5:43 AM, Tamás Cservenák <ta...@cservenak.net> wrote:
> In short: Java6 EOL is coming in months now, users running 1.5 and below
> should really consider an upgrade.
> A bit longer: Java6 1st release happened in 2006, 6 years ago. In our
> profession, that is around 70 years old, 6 years corresponds to -- for
> example in optics (first known lenses are about 700 BC according to
> wikipedia) -- to roughly 233 years. So, in case you wear spectacles, would
> you wear these today http://www.sptddog.com/sotp/18thcent.jpg ?
LOL.
> In essence: not really needed for now, as Lucene 3.6.1 is fine on Java5,
> and IOEx new constructor is used in very few places.... but we can go back
> in time for 233 years for now.
I don't have a problem with updating it if there's something useful to take advantage of, knowing the user-base of the library. In other libraries, we don't need to upgrade just for the sake of it, of course.
Perhaps with this requirement, and the API breakage you indicated, the version could bump to 5.0.0-SNAPSHOT? I like the semantic versioning rules (semver.org).
- Brett
--
Brett Porter
brett@apache.org
http://brettporter.wordpress.com/
http://au.linkedin.com/in/brettporter
http://twitter.com/brettporter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven Indexer Changes
Posted by Tamás Cservenák <ta...@cservenak.net>.
In short: Java6 EOL is coming in months now, users running 1.5 and below
should really consider an upgrade.
A bit longer: Java6 1st release happened in 2006, 6 years ago. In our
profession, that is around 70 years old, 6 years corresponds to -- for
example in optics (first known lenses are about 700 BC according to
wikipedia) -- to roughly 233 years. So, in case you wear spectacles, would
you wear these today http://www.sptddog.com/sotp/18thcent.jpg ?
In essence: not really needed for now, as Lucene 3.6.1 is fine on Java5,
and IOEx new constructor is used in very few places.... but we can go back
in time for 233 years for now.
Thanks,
~t~
On Wed, Aug 8, 2012 at 7:24 PM, Robert Scholte <rf...@apache.org> wrote:
> What's the reason for the "Bumped MI to Java6 level."?
> Looks like a potential issue to me (assuming a lot of projects still use
> java5)
>
> -Robert
>
> Op Wed, 08 Aug 2012 18:29:41 +0200 schreef Olivier Lamy <olamy@apache.org
> >:
>
>
> Nice changes.
>> +1 to merge that.
>> Maybe some jiras entries to create :-)
>>
>> --
>> Olivier
>> Le 7 août 2012 23:21, "Tamás Cservenák" <ta...@cservenak.net> a écrit :
>>
>> Hi there,
>>>
>>> Olivier did a great job of releasing Maven Indexer 4.1.3 that bumped
>>> Lucene
>>> to 3.6.1.
>>>
>>> But, having Lucene 3.6.1 in MI makes us now possible to do more. Here is
>>> a
>>> branch I did today:
>>> https://github.com/cstamas/**maven-indexer/commits/fixes<https://github.com/cstamas/maven-indexer/commits/fixes>
>>>
>>> Basically, it has following changes:
>>> * Removed heavy uses of StringBuffer, replaced with StringBuilder
>>> * Version bumped to 4.5.0-SNAP (from 4.1.4-SNAP) as changes below
>>> introduces API breakage (especially how you "acquire" IndexSearcher from
>>> context, needed to properly implement locking semantics)
>>> * Removed bottle warmer threads completely
>>> * Removed problematic locking around contexts as we rely now on Lucene
>>> * Using new SearcherManager (see
>>>
>>> http://blog.mikemccandless.**com/2011/09/lucenes-**
>>> searchermanager-simplifies.**html<http://blog.mikemccandless.com/2011/09/lucenes-searchermanager-simplifies.html>
>>> )
>>> instead of doing all this manually + relying on those removed stuff above
>>> * Removed deprecated baggage
>>>
>>> Changes above renders issues MINDEXER-52 and alike actually a
>>> "non-issues".
>>>
>>>
>>> Please comment the changes.
>>>
>>>
>>>
>>> Thanks,
>>> ~t~
>>>
>>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.**org<de...@maven.apache.org>
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: Maven Indexer Changes
Posted by Robert Scholte <rf...@apache.org>.
What's the reason for the "Bumped MI to Java6 level."?
Looks like a potential issue to me (assuming a lot of projects still use
java5)
-Robert
Op Wed, 08 Aug 2012 18:29:41 +0200 schreef Olivier Lamy <ol...@apache.org>:
> Nice changes.
> +1 to merge that.
> Maybe some jiras entries to create :-)
>
> --
> Olivier
> Le 7 août 2012 23:21, "Tamás Cservenák" <ta...@cservenak.net> a écrit :
>
>> Hi there,
>>
>> Olivier did a great job of releasing Maven Indexer 4.1.3 that bumped
>> Lucene
>> to 3.6.1.
>>
>> But, having Lucene 3.6.1 in MI makes us now possible to do more. Here
>> is a
>> branch I did today:
>> https://github.com/cstamas/maven-indexer/commits/fixes
>>
>> Basically, it has following changes:
>> * Removed heavy uses of StringBuffer, replaced with StringBuilder
>> * Version bumped to 4.5.0-SNAP (from 4.1.4-SNAP) as changes below
>> introduces API breakage (especially how you "acquire" IndexSearcher from
>> context, needed to properly implement locking semantics)
>> * Removed bottle warmer threads completely
>> * Removed problematic locking around contexts as we rely now on Lucene
>> * Using new SearcherManager (see
>>
>> http://blog.mikemccandless.com/2011/09/lucenes-searchermanager-simplifies.html
>> )
>> instead of doing all this manually + relying on those removed stuff
>> above
>> * Removed deprecated baggage
>>
>> Changes above renders issues MINDEXER-52 and alike actually a
>> "non-issues".
>>
>>
>> Please comment the changes.
>>
>>
>>
>> Thanks,
>> ~t~
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven Indexer Changes
Posted by Olivier Lamy <ol...@apache.org>.
Nice changes.
+1 to merge that.
Maybe some jiras entries to create :-)
--
Olivier
Le 7 août 2012 23:21, "Tamás Cservenák" <ta...@cservenak.net> a écrit :
> Hi there,
>
> Olivier did a great job of releasing Maven Indexer 4.1.3 that bumped Lucene
> to 3.6.1.
>
> But, having Lucene 3.6.1 in MI makes us now possible to do more. Here is a
> branch I did today:
> https://github.com/cstamas/maven-indexer/commits/fixes
>
> Basically, it has following changes:
> * Removed heavy uses of StringBuffer, replaced with StringBuilder
> * Version bumped to 4.5.0-SNAP (from 4.1.4-SNAP) as changes below
> introduces API breakage (especially how you "acquire" IndexSearcher from
> context, needed to properly implement locking semantics)
> * Removed bottle warmer threads completely
> * Removed problematic locking around contexts as we rely now on Lucene
> * Using new SearcherManager (see
>
> http://blog.mikemccandless.com/2011/09/lucenes-searchermanager-simplifies.html
> )
> instead of doing all this manually + relying on those removed stuff above
> * Removed deprecated baggage
>
> Changes above renders issues MINDEXER-52 and alike actually a "non-issues".
>
>
> Please comment the changes.
>
>
>
> Thanks,
> ~t~
>