You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/02 16:25:23 UTC
[GitHub] [apisix-ingress-controller] Iced-Sun opened a new issue #661: http[].match.exprs - ability to refer to the internal nginx variables
Iced-Sun opened a new issue #661:
URL: https://github.com/apache/apisix-ingress-controller/issues/661
### Issue description
I need use the `$proxy_protocol_server_port` variable in the match rules of ApisixRoute to do the http-to-https redirection.
We decided to terminate TLS at the load balancer, hence the annotation of `k8s.apisix.apache.org/http-to-https` won't work because it depends on `$scheme` which is always `http`. The proxy protocol could help with the `$proxy_protocol_server_port` variable but it demands the ablitity to be referred.
As a workaround, I created a redirection ApisixRoute and then added the 'vars' match rules manually, for now.
Is there any plan to enable ApisixRoute to refer to arbitary nginx variables? Or better, to support even in native Ingress (e.g. as annotations)?
Regards.
### Environment
* your apisix-ingress-controller version (output of `apisix-ingress-controller version --long`): 1.2.0
* your Kubernetes cluster version (output of `kubectl version`): 1.21.2-eks-0389ca3
* if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (`uname -a`): N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] Belyenochi removed a comment on issue #661: http[].match.exprs - ability to refer to the internal nginx variables
Posted by GitBox <gi...@apache.org>.
Belyenochi removed a comment on issue #661:
URL: https://github.com/apache/apisix-ingress-controller/issues/661#issuecomment-1041488157
> 👌
I'm a little confused, exprs can support some NginxVars, should we expand the fields based on ApisixRouteHTTPMatchExpr(in ApisixRoute CRD struct)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] Belyenochi commented on issue #661: http[].match.exprs - ability to refer to the internal nginx variables
Posted by GitBox <gi...@apache.org>.
Belyenochi commented on issue #661:
URL: https://github.com/apache/apisix-ingress-controller/issues/661#issuecomment-1041488003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #661: http[].match.exprs - ability to refer to the internal nginx variables
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #661:
URL: https://github.com/apache/apisix-ingress-controller/issues/661#issuecomment-1038957219
👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] Belyenochi removed a comment on issue #661: http[].match.exprs - ability to refer to the internal nginx variables
Posted by GitBox <gi...@apache.org>.
Belyenochi removed a comment on issue #661:
URL: https://github.com/apache/apisix-ingress-controller/issues/661#issuecomment-1041488003
> 👌
I'm a little confused, exprs can support some NginxVars, should we expand the fields based on ApisixRouteHTTPMatchExpr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] Belyenochi commented on issue #661: http[].match.exprs - ability to refer to the internal nginx variables
Posted by GitBox <gi...@apache.org>.
Belyenochi commented on issue #661:
URL: https://github.com/apache/apisix-ingress-controller/issues/661#issuecomment-1038955804
> > Previously the "easy to use" was the first thing we considered when we designed this feature. So some specific settings like `Query`, `Header` and etc were introduced.
> > We may add another setting like `NginxVar` to let People extend this feature, but apparently, it's not so friendly for users. @tao12345666333 What's your idea?
>
> Sorry, I have too many reminders, I missed this one.
>
> I think we should add this capability so that users can better utilize the capabilities of APISIX.
If no one else, please assign to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] vicaya commented on issue #661: http[].match.exprs - ability to refer to the internal nginx variables
Posted by GitBox <gi...@apache.org>.
vicaya commented on issue #661:
URL: https://github.com/apache/apisix-ingress-controller/issues/661#issuecomment-912083364
It'd be great if ApisixRoute can support `vars` option for route matching, as it's already supported by the `radixtree_uri_with_parameters` router, which I think is going to be the default anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] Belyenochi edited a comment on issue #661: http[].match.exprs - ability to refer to the internal nginx variables
Posted by GitBox <gi...@apache.org>.
Belyenochi edited a comment on issue #661:
URL: https://github.com/apache/apisix-ingress-controller/issues/661#issuecomment-1041488157
> 👌
I'm a little confused, exprs can support some NginxVars, should we expand the fields based on ApisixRouteHTTPMatchExpr(in ApisixRoute CRD struct)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] vicaya removed a comment on issue #661: http[].match.exprs - ability to refer to the internal nginx variables
Posted by GitBox <gi...@apache.org>.
vicaya removed a comment on issue #661:
URL: https://github.com/apache/apisix-ingress-controller/issues/661#issuecomment-912083364
It'd be great if ApisixRoute can support `vars` option for route matching, as it's already supported by the `radixtree_uri_with_parameters` router, which I think is going to be the default anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #661: http[].match.exprs - ability to refer to the internal nginx variables
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #661:
URL: https://github.com/apache/apisix-ingress-controller/issues/661#issuecomment-912200210
Previously the "easy to use" was the first thing we considered when we designed this feature. So some specific settings like `Query`, `Header` and etc were introduced.
We may add another setting like `NginxVar` to let People extend this feature, but apparently, it's not so friendly for users. @tao12345666333 What's your idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #661: http[].match.exprs - ability to refer to the internal nginx variables
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #661:
URL: https://github.com/apache/apisix-ingress-controller/issues/661#issuecomment-926254823
> Previously the "easy to use" was the first thing we considered when we designed this feature. So some specific settings like `Query`, `Header` and etc were introduced.
>
> We may add another setting like `NginxVar` to let People extend this feature, but apparently, it's not so friendly for users. @tao12345666333 What's your idea?
Sorry, I have too many reminders, I missed this one.
I think we should add this capability so that users can better utilize the capabilities of APISIX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org