You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/05/21 18:35:23 UTC

Review Request 21778: Added file permissions to open() call when O_CREAT is specified.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21778/
-----------------------------------------------------------

Review request for mesos, Till Toenshoff and Vinod Kone.


Bugs: MESOS-1402
    https://issues.apache.org/jira/browse/MESOS-1402


Repository: mesos-git


Description
-------

see summary.


Diffs
-----

  src/slave/containerizer/mesos_containerizer.cpp 9084082855d8f9da0c6eea094a107b4d02d344d0 

Diff: https://reviews.apache.org/r/21778/diff/


Testing
-------

make check


Thanks,

Dominic Hamon


Re: Review Request 21778: Added file permissions to open() call when O_CREAT is specified.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21778/#review43638
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On May 21, 2014, 4:54 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21778/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 4:54 p.m.)
> 
> 
> Review request for mesos, Till Toenshoff and Vinod Kone.
> 
> 
> Bugs: MESOS-1402
>     https://issues.apache.org/jira/browse/MESOS-1402
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos_containerizer.cpp 9084082855d8f9da0c6eea094a107b4d02d344d0 
> 
> Diff: https://reviews.apache.org/r/21778/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 21778: Added file permissions to open() call when O_CREAT is specified.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21778/
-----------------------------------------------------------

(Updated May 21, 2014, 9:54 a.m.)


Review request for mesos, Till Toenshoff and Vinod Kone.


Changes
-------

updated with respect to style guide. i think.


Bugs: MESOS-1402
    https://issues.apache.org/jira/browse/MESOS-1402


Repository: mesos-git


Description
-------

see summary.


Diffs (updated)
-----

  src/slave/containerizer/mesos_containerizer.cpp 9084082855d8f9da0c6eea094a107b4d02d344d0 

Diff: https://reviews.apache.org/r/21778/diff/


Testing
-------

make check


Thanks,

Dominic Hamon