You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Martin Harris <no...@github.com> on 2013/11/06 17:25:27 UTC
[jclouds] Changed return type of TemplateBuilder.imageChooser from
TemplateBuilderImpl to TemplateBuilder (#198)
You can merge this Pull Request by running:
git pull https://github.com/Nakomis/jclouds fix-imageChooser-return-type
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/198
-- Commit Summary --
* Changed return type of TemplateBuilder.imageChooser from TemplateBuilderImpl to TemplateBuilder
-- File Changes --
M compute/src/main/java/org/jclouds/compute/domain/TemplateBuilder.java (2)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/198.patch
https://github.com/jclouds/jclouds/pull/198.diff
Re: [jclouds] Changed return type of TemplateBuilder.imageChooser
from TemplateBuilderImpl to TemplateBuilder (#198)
Posted by ahgittin <no...@github.com>.
My mistake in https://issues.apache.org/jira/browse/JCLOUDS-331 .
This fix looks good. Should also be backported to 1.6.x (along with JCLOUDS-331).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/198#issuecomment-27898538
Re: [jclouds] Changed return type of TemplateBuilder.imageChooser
from TemplateBuilderImpl to TemplateBuilder (#198)
Posted by Andrew Phillips <no...@github.com>.
> @@ -177,7 +177,7 @@
> * If no function is supplied, jclouds will select one according to an internal strategy.
> * This strategy may change from version to version.
> */
> - TemplateBuilderImpl imageChooser(Function<Iterable<? extends Image>,Image> imageChooser);
> + TemplateBuilder imageChooser(Function<Iterable<? extends Image>,Image> imageChooser);
[minor] Space before `Image`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/198/files#r7485730
Re: [jclouds] Changed return type of TemplateBuilder.imageChooser
from TemplateBuilderImpl to TemplateBuilder (#198)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #835](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/835/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/198#issuecomment-27890211
Re: [jclouds] Changed return type of TemplateBuilder.imageChooser
from TemplateBuilderImpl to TemplateBuilder (#198)
Posted by Andrew Phillips <no...@github.com>.
+1 - looks good to me. Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=ca8289b692911a4385b20c9ad422d3efc362fb9e)
Thanks, @Nakomis and @ahgittin!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/198#issuecomment-27933404
Re: [jclouds] Changed return type of TemplateBuilder.imageChooser
from TemplateBuilderImpl to TemplateBuilder (#198)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #372](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/372/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/198#issuecomment-27890200