[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #904: netutils/dhcpc: add non-blocking interface

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on PR #904:
URL: https://github.com/apache/incubator-nuttx-apps/pull/904#issuecomment-1166462314

   > fyi: I tried to use this code (adding a `dhcpc` daemon based on the `ntpc` daemon), but it has a couple of nasty bugs:
   > 
   > * it doesn't renew dhcp leases, but rather does full re-discovery and request (as if it had never seen the network before),
   
   yes, we can optimize in this case.
   
   > * you can't start `dhcpc_request_async` from `netinit_net_bringup`, and later call `dhcpc_close` from nsh:
   >   
   >   * the socket isn't closed properly, not sure why (it works fine when calling `dhcpc_request_async` from nsh),
   
   does you call dhcpc_request_async and dhcpc_close from the different task?
   
   > * the interface name stored in `dhcpc_state_s` isn't duplicated, so the name is lost when the caller frees the underlying string,
   
   The design want to save one string copy, and is easy to use copy instead.
   
   > * sometimes it sees a double-offer, it it will decline it even if it's just a duplicate of the offer that it's just received.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org