[GitHub] [flink] Myasuka commented on a change in pull request #10820: [FLINK-15512][statebackend] Refactor the mechanism to calculate the cache capacity shared among RocksDB instance(s)

[GitBox <gi...@apache.org>]

Myasuka commented on a change in pull request #10820: [FLINK-15512][statebackend] Refactor the mechanism to calculate the cache capacity shared among RocksDB instance(s)
URL: https://github.com/apache/flink/pull/10820#discussion_r365275814
 
 

 ##########
 File path: docs/_includes/generated/rocks_db_configuration.html
 ##########
 @@ -30,7 +30,7 @@
             <td><h5>state.backend.rocksdb.memory.high-prio-pool-ratio</h5></td>
             <td style="word-wrap: break-word;">0.1</td>
             <td>Double</td>
-            <td>The fraction of cache memory that is reserved for high-priority data like index, filter, and compression dictionary blocks. This option only has an effect when 'state.backend.rocksdb.memory.managed' or 'state.backend.rocksdb.memory.fixed-per-slot' are configured.</td>
+            <td>The fraction of total shared memory that is reserved for high-priority data like index, filter, and compression dictionary blocks. This option only has an effect when 'state.backend.rocksdb.memory.managed' or 'state.backend.rocksdb.memory.fixed-per-slot' are configured.</td>
 
 Review comment:
   Thanks for pointing out, it should not be changed here since the ratio is really used by the cache.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services