You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/12/29 08:30:36 UTC
[GitHub] [dubbo-go-hessian2] alpha-baby opened a new pull request #303: reproduce decode interface map bug #299
alpha-baby opened a new pull request #303:
URL: https://github.com/apache/dubbo-go-hessian2/pull/303
<!-- Thanks for sending a pull request!
-->
#299
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on a change in pull request #303: reproduce decode interface map bug #299
Posted by GitBox <gi...@apache.org>.
wongoo commented on a change in pull request #303:
URL: https://github.com/apache/dubbo-go-hessian2/pull/303#discussion_r776238414
##########
File path: decode_test.go
##########
@@ -223,7 +223,7 @@ func TestIssue299HessianDecode(t *testing.T) {
"interface_slice": []interface{}{
"MyName",
},
- "interface_map": map[string]interface{}{
Review comment:
currently hessian2 default encode as untyped map, see https://github.com/apache/dubbo-go-hessian2/blob/master/map.go#L122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] alpha-baby commented on a change in pull request #303: reproduce decode interface map bug #299
Posted by GitBox <gi...@apache.org>.
alpha-baby commented on a change in pull request #303:
URL: https://github.com/apache/dubbo-go-hessian2/pull/303#discussion_r776236871
##########
File path: decode_test.go
##########
@@ -223,7 +223,7 @@ func TestIssue299HessianDecode(t *testing.T) {
"interface_slice": []interface{}{
"MyName",
},
- "interface_map": map[string]interface{}{
Review comment:
unsuport specific key types ??
I have tried Java and it is supported this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] alpha-baby commented on a change in pull request #303: reproduce decode interface map bug #299
Posted by GitBox <gi...@apache.org>.
alpha-baby commented on a change in pull request #303:
URL: https://github.com/apache/dubbo-go-hessian2/pull/303#discussion_r776240524
##########
File path: decode_test.go
##########
@@ -223,7 +223,7 @@ func TestIssue299HessianDecode(t *testing.T) {
"interface_slice": []interface{}{
"MyName",
},
- "interface_map": map[string]interface{}{
Review comment:
> @alpha-baby default encoding as untyped map does not match the hessian2 protocol, u are welcome to fix it if u will
ok, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on a change in pull request #303: reproduce decode interface map bug #299
Posted by GitBox <gi...@apache.org>.
wongoo commented on a change in pull request #303:
URL: https://github.com/apache/dubbo-go-hessian2/pull/303#discussion_r776239628
##########
File path: decode_test.go
##########
@@ -223,7 +223,7 @@ func TestIssue299HessianDecode(t *testing.T) {
"interface_slice": []interface{}{
"MyName",
},
- "interface_map": map[string]interface{}{
Review comment:
@alpha-baby default encoding as untyped map does not match the hessian2 protocol, u are welcome to fix it if u will
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks merged pull request #303: reproduce decode interface map bug #299
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #303:
URL: https://github.com/apache/dubbo-go-hessian2/pull/303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org