You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/03 19:41:35 UTC

[GitHub] [geode] jhutchison commented on pull request #5954: GEODE-8864:finish implementation of Redis HScan Command

jhutchison commented on pull request #5954:
URL: https://github.com/apache/geode/pull/5954#issuecomment-790004759


   @sabbey (for some reason this particular comment won't let me reply on it )
   
   regarding the test givenCount_returnsAllEntriesWithoutDuplicates() mentioned above- that test seemed not super valuable like it was (testing that the entire set was returned), so I changed it a little and moved it to the (concrete) HScanIntegrationTest (since our implementation doesn't really match native Redis' exactly. ).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org