You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/06/24 01:11:29 UTC
[GitHub] [incubator-iotdb] SailVR opened a new pull request #1417: [IOTDB-774]Handle result of "show timeseries" as iterator
SailVR opened a new pull request #1417:
URL: https://github.com/apache/incubator-iotdb/pull/1417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] SailVR closed pull request #1417: [IOTDB-774]Handle result of "show timeseries" as iterator
Posted by GitBox <gi...@apache.org>.
SailVR closed pull request #1417:
URL: https://github.com/apache/incubator-iotdb/pull/1417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] SailVR commented on pull request #1417: [IOTDB-774]Handle result of "show timeseries" as iterator
Posted by GitBox <gi...@apache.org>.
SailVR commented on pull request #1417:
URL: https://github.com/apache/incubator-iotdb/pull/1417#issuecomment-650736641
> Please fix the potential bugs according to the failed tests in `IoTDBSortedShowTimeseriesIT`, `IoTDBTagAlterIT` and `IoTDBTagIT`
OKļ¼Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #1417: [IOTDB-774]Handle result of "show timeseries" as iterator
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on a change in pull request #1417:
URL: https://github.com/apache/incubator-iotdb/pull/1417#discussion_r446783276
##########
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##########
@@ -500,7 +501,14 @@ private TSExecuteStatementResp internalExecuteQueryStatement(String statement,
long queryId = -1;
try {
TSExecuteStatementResp resp = getQueryResp(plan, username); // column headers
-
+
+ if(plan instanceof ShowTimeSeriesPlan){
+ if (plan instanceof ShowTimeSeriesPlan) {
Review comment:
Duplicated?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] SailVR commented on a change in pull request #1417: [IOTDB-774]Handle result of "show timeseries" as iterator
Posted by GitBox <gi...@apache.org>.
SailVR commented on a change in pull request #1417:
URL: https://github.com/apache/incubator-iotdb/pull/1417#discussion_r446787390
##########
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##########
@@ -500,7 +501,14 @@ private TSExecuteStatementResp internalExecuteQueryStatement(String statement,
long queryId = -1;
try {
TSExecuteStatementResp resp = getQueryResp(plan, username); // column headers
-
+
+ if(plan instanceof ShowTimeSeriesPlan){
+ if (plan instanceof ShowTimeSeriesPlan) {
Review comment:
modified
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org