[GitHub] [incubator-hugegraph-computer] imbajin commented on a diff in pull request #227: chore: fix StringEncoding license & add multi license check action

["imbajin (via GitHub)" <gi...@apache.org>]

imbajin commented on code in PR #227:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/227#discussion_r1099921401


##########
LICENSE:
##########
@@ -200,3 +200,11 @@
    See the License for the specific language governing permissions and
    limitations under the License.
    
+========================================================================
+Apache 2.0 licenses
+========================================================================
+
+The following components are provided under the Apache License. See project link for details.
+The text of each license is the standard Apache 2.0 license.
+
+computer-core/src/main/java/org/apache/hugegraph/computer/core/util/StringEncoding.java files from https://github.com/JanusGraph

Review Comment:
   @javeme maybe this file should move to commons, so that we don't need to import the same refer in multi repo



##########
computer-dist/release-docs/LICENSE:
##########
@@ -497,9 +499,9 @@ The following components are provided under the Public Domain License.
     (Public Domain, per Creative Commons CC0) * XZ for Java(org.tukaani:xz:1.8-https://tukaani.org/xz/java.html )
 
 ========================================================================
-Third party Go licens
+Third party Go license
 ========================================================================
 
-The following components are provided under The Go licens.
+The following components are provided under The Go license.

Review Comment:
   @simon824 I correct the typo, ensure is this as expected?



##########
computer-core/src/main/java/org/apache/hugegraph/computer/core/util/StringEncoding.java:
##########
@@ -44,7 +28,6 @@
 
 /**
  * @author Matthias Broecheler (me@matthiasb.com)
- * @author HugeGraph Authors

Review Comment:
   I'm not sure whether we can add a **new author**, so temporarily remove it
   
   Restore it after confirmation maybe



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org