You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/21 17:08:53 UTC
[GitHub] [airflow] mik-laj opened a new pull request #13224: Support google-cloud-datacatalog 3.0.0
mik-laj opened a new pull request #13224:
URL: https://github.com/apache/airflow/pull/13224
Depends on: https://github.com/apache/airflow/pull/13097
Part of: https://github.com/apache/airflow/issues/12116
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13224: Support google-cloud-datacatalog 3.0.0
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13224:
URL: https://github.com/apache/airflow/pull/13224#discussion_r549268913
##########
File path: airflow/providers/google/cloud/hooks/datacatalog.py
##########
@@ -18,16 +18,18 @@
from typing import Dict, Optional, Sequence, Tuple, Union
from google.api_core.retry import Retry
-from google.cloud.datacatalog_v1beta1 import DataCatalogClient
-from google.cloud.datacatalog_v1beta1.types import (
+from google.cloud import datacatalog
+from google.cloud.datacatalog_v1beta1 import (
+ CreateTagRequest,
+ DataCatalogClient,
Entry,
EntryGroup,
- FieldMask,
SearchCatalogRequest,
Tag,
TagTemplate,
TagTemplateField,
)
+from google.protobuf import field_mask_pb2 as field_mask # type: ignore
Review comment:
```suggestion
from google.protobuf.field_mask_pb2 import FieldMask
```
Should we keep it unified with import in other places?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #13224: Support google-cloud-datacatalog 3.0.0
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #13224:
URL: https://github.com/apache/airflow/pull/13224
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13224: Support google-cloud-datacatalog 3.0.0
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13224:
URL: https://github.com/apache/airflow/pull/13224#discussion_r549292567
##########
File path: airflow/providers/google/cloud/hooks/datacatalog.py
##########
@@ -18,16 +18,18 @@
from typing import Dict, Optional, Sequence, Tuple, Union
from google.api_core.retry import Retry
-from google.cloud.datacatalog_v1beta1 import DataCatalogClient
-from google.cloud.datacatalog_v1beta1.types import (
+from google.cloud import datacatalog
+from google.cloud.datacatalog_v1beta1 import (
+ CreateTagRequest,
+ DataCatalogClient,
Entry,
EntryGroup,
- FieldMask,
SearchCatalogRequest,
Tag,
TagTemplate,
TagTemplateField,
)
+from google.protobuf import field_mask_pb2 as field_mask # type: ignore
Review comment:
It just copied these lines from the Google library, but it will delete the alias, because it is not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #13224: Support google-cloud-datacatalog 3.0.0
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #13224:
URL: https://github.com/apache/airflow/pull/13224#issuecomment-754169592
The Pylint check in master is broken. Based on the files pointed by Pylint, seems it's related to this PR. I'm taking a look into it, also FYI @mik-laj @potiuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13224: Support google-cloud-datacatalog 3.0.0
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13224:
URL: https://github.com/apache/airflow/pull/13224#issuecomment-754201788
Strange. They seemed to pass in the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13224: Support google-cloud-datacatalog 3.0.0
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13224:
URL: https://github.com/apache/airflow/pull/13224#issuecomment-754229276
I did a rebase this morning. i also have all the fancy labels for this PR, but it seems me the problem may be with the constraints file that contains the old version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13224: Support google-cloud-datacatalog 3.0.0
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13224:
URL: https://github.com/apache/airflow/pull/13224#issuecomment-752952075
Can you please rebase to latest version @mik-laj ? We will likely need to check if it works as intended with uprading to latest deps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13224: Support google-cloud-datacatalog 3.0.0
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13224:
URL: https://github.com/apache/airflow/pull/13224#issuecomment-754245780
@mik-laj This is the error:
```
E AssertionError: 0 != 1 : import_errors={'/opt/airflow/airflow/providers/google/cloud/example_dags/example_datacatalog.py': 'Traceback (most recent call last):\n File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed\n File "/opt/airflow/airflow/providers/google/cloud/example_dags/example_datacatalog.py", line 22, in <module>\n from google.cloud.datacatalog_v1beta1 import FieldType, TagField, TagTemplateField\nImportError: cannot import name \'FieldType\'\n'}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #13224: Support google-cloud-datacatalog 3.0.0
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #13224:
URL: https://github.com/apache/airflow/pull/13224#issuecomment-752952075
Can you please rebase to latest version @mik-laj ? We will likely need to check if it works as intended with upgrading to latest deps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13224: Support google-cloud-datacatalog 3.0.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13224:
URL: https://github.com/apache/airflow/pull/13224#issuecomment-752951991
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org