You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ksonj <gi...@git.apache.org> on 2015/04/29 09:49:35 UTC
[GitHub] spark pull request: Better error message on access to non-existing...
GitHub user ksonj opened a pull request:
https://github.com/apache/spark/pull/5771
Better error message on access to non-existing attribute
I believe column access via `__getattr__` is bad and shouldn't be implicitly encouraged by the error message when accessing a non-existing attribute on DataFrame. This patch changes the error message from 'no such column' to the more generic 'no such attribute', which is also what Pandas DFs will throw.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ksonj/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5771.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5771
----
commit bcc222084c2fefcb9482cf52d6bb50078ef34377
Author: ksonj <ks...@siberie.de>
Date: 2015-04-29T07:17:36Z
Better error message on access to non-existing attribute
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Better error message on access to non-existing...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5771#issuecomment-97338032
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Better error message on access to non-existing...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5771#issuecomment-97339403
[Test build #31263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31263/consoleFull) for PR 5771 at commit [`bcc2220`](https://github.com/apache/spark/commit/bcc222084c2fefcb9482cf52d6bb50078ef34377).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Better error message on access to non-existing...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5771
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Better error message on access to non-existing...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5771#issuecomment-97372177
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31263/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Better error message on access to non-existing...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5771#issuecomment-97338881
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Better error message on access to non-existing...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5771#issuecomment-97372176
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Better error message on access to non-existing...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5771#issuecomment-97339228
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Better error message on access to non-existing...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5771#issuecomment-97339216
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Better error message on access to non-existing...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5771#issuecomment-97372166
[Test build #31263 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31263/consoleFull) for PR 5771 at commit [`bcc2220`](https://github.com/apache/spark/commit/bcc222084c2fefcb9482cf52d6bb50078ef34377).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class Hypot(`
* `case class Pow(left: Expression, right: Expression) extends BinaryMathExpression(math.pow, "POWER")`
* `abstract class MathematicalExpression(f: Double => Double, name: String)`
* `case class Acos(child: Expression) extends MathematicalExpression(math.acos, "ACOS")`
* `case class Asin(child: Expression) extends MathematicalExpression(math.asin, "ASIN")`
* `case class Atan(child: Expression) extends MathematicalExpression(math.atan, "ATAN")`
* `case class Cbrt(child: Expression) extends MathematicalExpression(math.cbrt, "CBRT")`
* `case class Ceil(child: Expression) extends MathematicalExpression(math.ceil, "CEIL")`
* `case class Cos(child: Expression) extends MathematicalExpression(math.cos, "COS")`
* `case class Cosh(child: Expression) extends MathematicalExpression(math.cosh, "COSH")`
* `case class Exp(child: Expression) extends MathematicalExpression(math.exp, "EXP")`
* `case class Expm1(child: Expression) extends MathematicalExpression(math.expm1, "EXPM1")`
* `case class Floor(child: Expression) extends MathematicalExpression(math.floor, "FLOOR")`
* `case class Log(child: Expression) extends MathematicalExpression(math.log, "LOG")`
* `case class Log10(child: Expression) extends MathematicalExpression(math.log10, "LOG10")`
* `case class Log1p(child: Expression) extends MathematicalExpression(math.log1p, "LOG1P")`
* `case class Rint(child: Expression) extends MathematicalExpression(math.rint, "ROUND")`
* `case class Signum(child: Expression) extends MathematicalExpression(math.signum, "SIGNUM")`
* `case class Sin(child: Expression) extends MathematicalExpression(math.sin, "SIN")`
* `case class Sinh(child: Expression) extends MathematicalExpression(math.sinh, "SINH")`
* `case class Tan(child: Expression) extends MathematicalExpression(math.tan, "TAN")`
* `case class Tanh(child: Expression) extends MathematicalExpression(math.tanh, "TANH")`
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Better error message on access to non-existing...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5771#issuecomment-97501158
Thanks. I'm merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org