[GitHub] ivankelly opened a new pull request #775: Tests wait for client to see started bookie

[GitBox <gi...@apache.org>]

ivankelly opened a new pull request #775: Tests wait for client to see started bookie
URL: https://github.com/apache/bookkeeper/pull/775
 
 
   Up until now we were only waiting for the bookie to exist in the
   bookie list, after which we triggered a read. However, when the
   registration changes went in, the read wasn't actually populating the
   mechanism used to select bookies, so we ended up momentarily having
   unusable bookkeeper clients until the correct read triggered. This
   resulted in flakiness in random tests.
   
   This change makes it so we wait until the client has seen a bookie
   before startBookie will return. It also makes sure that reading the
   bookie list actually populates the bookie selection mechanism.
   
   Descriptions of the changes in this PR:
   
   (PR description content here)...
   
   > ---
   > Be sure to do all of the following to help us incorporate your contribution
   > quickly and easily:
   > 
   > - [ ] Make sure the PR title is formatted like:
   >     `<Issue # or BOOKKEEPER-#>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   >     `e.g. BOOKKEEPER-1234: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install findbugs:check`.
   > - [ ] Replace `<Issue # or BOOKKEEPER-#>` in the title with the actual Issue/JIRA number.
   > 
   > ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services