You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/12/02 19:15:59 UTC
[kudu-CR] mvcc: some locking cleanup
Hello Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14816
to review the following change.
Change subject: mvcc: some locking cleanup
......................................................................
mvcc: some locking cleanup
Close was notifying waiters before erasing them from the waiters_ list. In
practice this didn't matter: lock_ was always held around any manipulation
of waiters_. But for consistency, let's do what AdjustCleanTime does.
AdjustCleanTime required lock_ to be held, so let's enforce that.
Change-Id: I189553d0f589794ad830a30b3c0b4ce5fd5569ba
---
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/mvcc.h
2 files changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/14816/1
--
To view, visit http://gerrit.cloudera.org:8080/14816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I189553d0f589794ad830a30b3c0b4ce5fd5569ba
Gerrit-Change-Number: 14816
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] mvcc: some locking cleanup
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14816 )
Change subject: mvcc: some locking cleanup
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I189553d0f589794ad830a30b3c0b4ce5fd5569ba
Gerrit-Change-Number: 14816
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Dec 2019 03:35:25 +0000
Gerrit-HasComments: No
[kudu-CR] mvcc: some locking cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14816
to look at the new patch set (#2).
Change subject: mvcc: some locking cleanup
......................................................................
mvcc: some locking cleanup
Close was notifying waiters before erasing them from the waiters_ list. In
practice this didn't matter: lock_ was always held around any manipulation
of waiters_. But for consistency, let's do what AdjustCleanTime does.
AdjustCleanTime required lock_ to be held, so let's enforce that.
Change-Id: I189553d0f589794ad830a30b3c0b4ce5fd5569ba
---
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/mvcc.h
2 files changed, 13 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/14816/2
--
To view, visit http://gerrit.cloudera.org:8080/14816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I189553d0f589794ad830a30b3c0b4ce5fd5569ba
Gerrit-Change-Number: 14816
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] mvcc: some locking cleanup
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14816 )
Change subject: mvcc: some locking cleanup
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I189553d0f589794ad830a30b3c0b4ce5fd5569ba
Gerrit-Change-Number: 14816
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Dec 2019 22:54:29 +0000
Gerrit-HasComments: No
[kudu-CR] mvcc: some locking cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14816 )
Change subject: mvcc: some locking cleanup
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14816/1/src/kudu/tablet/mvcc.cc
File src/kudu/tablet/mvcc.cc:
http://gerrit.cloudera.org:8080/#/c/14816/1/src/kudu/tablet/mvcc.cc@230
PS1, Line 230: (*iter)->latch->CountDown();
> What if 'iter' returned at line 229 is waiters_.end()?
Good catch. I'll fix this.
--
To view, visit http://gerrit.cloudera.org:8080/14816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I189553d0f589794ad830a30b3c0b4ce5fd5569ba
Gerrit-Change-Number: 14816
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Dec 2019 21:03:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] mvcc: some locking cleanup
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14816 )
Change subject: mvcc: some locking cleanup
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14816/1/src/kudu/tablet/mvcc.cc
File src/kudu/tablet/mvcc.cc:
http://gerrit.cloudera.org:8080/#/c/14816/1/src/kudu/tablet/mvcc.cc@230
PS1, Line 230: (*iter)->latch->CountDown();
What if 'iter' returned at line 229 is waiters_.end()?
--
To view, visit http://gerrit.cloudera.org:8080/14816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I189553d0f589794ad830a30b3c0b4ce5fd5569ba
Gerrit-Change-Number: 14816
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Dec 2019 04:09:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] mvcc: some locking cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14816 )
Change subject: mvcc: some locking cleanup
......................................................................
mvcc: some locking cleanup
Close was notifying waiters before erasing them from the waiters_ list. In
practice this didn't matter: lock_ was always held around any manipulation
of waiters_. But for consistency, let's do what AdjustCleanTime does.
AdjustCleanTime required lock_ to be held, so let's enforce that.
Change-Id: I189553d0f589794ad830a30b3c0b4ce5fd5569ba
Reviewed-on: http://gerrit.cloudera.org:8080/14816
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/mvcc.h
2 files changed, 13 insertions(+), 8 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I189553d0f589794ad830a30b3c0b4ce5fd5569ba
Gerrit-Change-Number: 14816
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)