You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2018/05/02 08:26:13 UTC

[GitHub] flink pull request #5901: [FLINK-9235][Security] Add integration tests for Y...

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5901#discussion_r185423908
  
    --- Diff: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java ---
    @@ -85,54 +88,75 @@ public void checkForProhibitedLogContents() {
     	public void testDetachedMode() throws InterruptedException, IOException {
     		LOG.info("Starting testDetachedMode()");
     		addTestAppender(FlinkYarnSessionCli.class, Level.INFO);
    -		Runner runner =
    -			startWithArgs(new String[]{"-j", flinkUberjar.getAbsolutePath(),
    -						"-t", flinkLibFolder.getAbsolutePath(),
    -						"-n", "1",
    -						"-jm", "768",
    -						"-tm", "1024",
    -						"--name", "MyCustomName", // test setting a custom name
    -						"--detached"},
    -				"Flink JobManager is now running on", RunTypes.YARN_SESSION);
    -
    +		File exampleJarLocation = getTestJarPath("StreamingWordCount.jar");
    +		// get temporary file for reading input data for wordcount example
    +		File tmpInFile;
    +		try {
    +			tmpInFile = tmp.newFile();
    +			FileUtils.writeStringToFile(tmpInFile, WordCountData.TEXT);
    +		}
    +		catch (IOException e) {
    +			throw new RuntimeException(e);
    +		}
    +		Runner runner = isNewMode ?
    --- End diff --
    
    Why do we need this change? Was it always starting in legacy mode before?


---