You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/30 08:53:54 UTC

[GitHub] [cloudstack-kubernetes-provider] davidjumani opened a new pull request #24: Changing beta labels to updated ones

davidjumani opened a new pull request #24:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/24


   Fixes #13 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on a change in pull request #24: Changing beta labels to updated ones

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #24:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/24#discussion_r522819039



##########
File path: README.md
##########
@@ -79,9 +79,8 @@ This will treat the node as 'uninitialized' and cause the CCM to apply metadata
 
 Supported labels are:
 * kubernetes.io/hostname (= the instance name)
-* beta.kubernetes.io/instance-type (= the compute offering)
-* failure-domain.beta.kubernetes.io/zone (= the zone)
-* failure-domain.beta.kubernetes.io/region (also = the zone)
+* node.kubernetes.io/instance-type (= the compute offering)
+* topology.kubernetes.io/region (= the zone)
 

Review comment:
       @onitake Changes made




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #24: Changing beta labels to updated ones

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #24:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/24#issuecomment-822965778


   @onitake @joschi36 are you lgtm on merging this? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #24: Changing beta labels to updated ones

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #24:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/24#issuecomment-719428108


   @onitake Looks good ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on pull request #24: Changing beta labels to updated ones

Posted by GitBox <gi...@apache.org>.
joschi36 commented on pull request #24:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/24#issuecomment-823079510


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #24: Changing beta labels to updated ones

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #24:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/24


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org