You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/02 23:13:06 UTC

[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #11902: fix: add fix for extra comments for #11781

graceguo-supercat opened a new pull request #11902:
URL: https://github.com/apache/incubator-superset/pull/11902


   ### SUMMARY
   There were a few minor fixes to address the comment in #11781. But i accidentally merged PR without the last commit.
   1) reduce SQL Editor height from 25 rows => 20 rows
   2) add background color for disabled SQL Editor
   3) fix unit test.
   
   ### TEST PLAN
   CI and manual test
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #11781
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat merged pull request #11902: fix: add fix for extra comments for #11781

Posted by GitBox <gi...@apache.org>.
graceguo-supercat merged pull request #11902:
URL: https://github.com/apache/incubator-superset/pull/11902


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org