You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by "phaniarnab (via GitHub)" <gi...@apache.org> on 2023/07/04 10:51:39 UTC

[GitHub] [systemds] phaniarnab commented on a diff in pull request #1849: [SYSTEMDS-3544] Boolean Matrix Support

phaniarnab commented on code in PR #1849:
URL: https://github.com/apache/systemds/pull/1849#discussion_r1251861601


##########
src/main/java/org/apache/sysds/common/Types.java:
##########
@@ -76,7 +76,7 @@ public boolean isUnknown() {
 	 */
 	public enum ValueType {
 		UINT4, UINT8, // Used for parsing in UINT values from numpy.
-		FP32, FP64, INT32, INT64, BOOLEAN, STRING, UNKNOWN,
+		FP32, FP64, INT32, INT64, BOOLEAN, TRUE_BOOLEAN, STRING, UNKNOWN,

Review Comment:
   Yes. That is a better approach and makes integrating the boolean type into the system easier.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org