[GitHub] cloudstack pull request: CLOUDSTACK-9184: [VMware] vmware.ports.pe...

[GabrielBrascher <gi...@git.apache.org>]

Github user GabrielBrascher commented on the pull request:

    https://github.com/apache/cloudstack/pull/1253#issuecomment-192951641
  
    @sureshanaparti Although it might be a bit tricky, I believe that the ideal solution would be to check for the hypervisor version; if it is 4.1/4.0 then the default value of 8 is changed to 256 (or any recommended amount for the given version). This way does not rely on admin to manually configure it (the idea would be to consider the global configuration if the admin set it, would just change a default value).
    
    I checked and maybe a method for check the hypervisor version and set the **_portsPerDvPortGroup** could be called by **com.cloud.hypervisor.vmware.manager.VmwareManagerImpl.addHostToPodCluster(VmwareContext, long, Long, Long, String)**. This method would search a host using the clusterId (**com.cloud.host.dao.HostDaoImpl.findByClusterId(Long)**); with the given HostVO it verifies the hypervisor version (**com.cloud.host.HostVO.getHypervisorVersion()**) to set the default value according this version.
    
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---