You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/01/14 19:49:18 UTC

[GitHub] [trafficcontrol] mitchell852 opened a new issue #5437: Consider breaking the go-test github action down by TC component

mitchell852 opened a new issue #5437:
URL: https://github.com/apache/trafficcontrol/issues/5437


   ## I'm submitting a ...
   -  improvement request (usability, performance, tech debt, etc.)
   
   ## Traffic Control components affected ...
   <!-- delete all those that don't apply -->
   -  Traffic Monitor
   -  Traffic Ops
   -  Traffic Ops ORT
   -  Traffic Stats
   -  CI tests
   
   ## Current behavior:
   Currently the Go unit tests for Grove, TM, TO, ORT and TS are contained within the go-test GHA and the readme doesn't make it clear the scope of testing involved in this GHA.
   
   ## New behavior:
   Consider breaking the GHA into grove-unit-tests, tm-unit-tests, to-unit-tests, ort-unit-tests, ts-unit-tests to make it very clear the extent of testing being run against PRs.
   
   <!--
       Licensed to the Apache Software Foundation (ASF) under one
       or more contributor license agreements.  See the NOTICE file
       distributed with this work for additional information
       regarding copyright ownership.  The ASF licenses this file
       to you under the Apache License, Version 2.0 (the
       "License"); you may not use this file except in compliance
       with the License.  You may obtain a copy of the License at
   
       https://apache.org/licenses/LICENSE-2.0
   
       Unless required by applicable law or agreed to in writing,
       software distributed under the License is distributed on an
       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       KIND, either express or implied.  See the License for the
       specific language governing permissions and limitations
       under the License.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 commented on issue #5437: Consider breaking the go-test github action down by TC component

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #5437:
URL: https://github.com/apache/trafficcontrol/issues/5437#issuecomment-760489139


   The README doesn't make it clear what the scope is because the README is for the action. The action has no scope at all, the scope is provided by the workflow.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mitchell852 commented on issue #5437: Consider breaking the go-test github action down by TC component

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #5437:
URL: https://github.com/apache/trafficcontrol/issues/5437#issuecomment-760504207


   > The README doesn't make it clear what the scope is because the README is for the action. The action has no scope at all, the scope is provided by the workflow.
   
   oh, so should i be looking here to get a better sense of the scope of the test-related workflows: https://github.com/apache/trafficcontrol/tree/master/.github/workflows
   
   So in that case, would it make sense instead to split out the go.unit.tests.yaml file?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 commented on issue #5437: Consider breaking the go-test github action down by TC component

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #5437:
URL: https://github.com/apache/trafficcontrol/issues/5437#issuecomment-760506553


   Yes, that's where you should look.
   
   I think if anything it'd be better to split the tests into jobs in a single workflow file. But to be honest it doesn't really much bother me the way it is now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #5437: Consider breaking the go-test github action down by TC component

Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #5437:
URL: https://github.com/apache/trafficcontrol/issues/5437#issuecomment-760504207


   > The README doesn't make it clear what the scope is because the README is for the action. The action has no scope at all, the scope is provided by the workflow.
   
   oh, so should i be looking here to get a better sense of the scope of the test-related workflows: https://github.com/apache/trafficcontrol/tree/master/.github/workflows
   
   So in that case, would it make sense instead to split out the go.unit.tests.yaml file? into to.unit.tests.yaml, tm.unit.tests.yaml, etc...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org