You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org> on 2006/10/31 16:10:18 UTC
[jira] Updated: (QPID-11) Move protocol literals from code to
AMQConstant
[ http://issues.apache.org/jira/browse/QPID-11?page=all ]
Marnie McCormack updated QPID-11:
---------------------------------
Fix Version/s: M2
> Move protocol literals from code to AMQConstant
> -----------------------------------------------
>
> Key: QPID-11
> URL: http://issues.apache.org/jira/browse/QPID-11
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client
> Reporter: Martin Ritchie
> Priority: Trivial
> Fix For: M2
>
>
> The current Java code has the odd literal value. Such as this from AMQMessage:
> return _contentHeaderBody.properties instanceof BasicContentHeaderProperties
> &&((BasicContentHeaderProperties) _contentHeaderBody.properties).getDeliveryMode() == 2;
> What is deliverymode 2?
> Out of context it makes it hard to understand. Something like AMQConstants.PersistentDeliveryMode would help reuse and minimise the impact of any protocol changes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira