Re: [PR] MINIFICPP-2558 Revamp site to site communication [nifi-minifi-cpp]

["lordgamez (via GitHub)" <gi...@apache.org>]

lordgamez commented on code in PR #1966:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1966#discussion_r2251990479


##########
libminifi/src/sitetosite/HttpSiteToSiteClient.cpp:
##########
@@ -0,0 +1,415 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "sitetosite/HttpSiteToSiteClient.h"
+
+#include <chrono>
+#include <map>
+#include <string>
+#include <memory>
+#include <thread>
+#include <iostream>
+#include <vector>
+#include <optional>
+
+#include "io/CRCStream.h"
+#include "sitetosite/Peer.h"
+#include "io/validation.h"
+#include "core/Resource.h"
+#include "utils/StringUtils.h"
+#include "Exception.h"
+
+#include "rapidjson/document.h"
+#include "rapidjson/error/en.h"
+
+#undef DELETE  // macro on windows
+
+namespace org::apache::nifi::minifi::sitetosite {
+
+namespace {
+std::optional<utils::Identifier> parseTransactionId(const std::string &uri) {
+  return utils::Identifier::parse(utils::string::partAfterLastOccurrenceOf(uri, '/'));
+}
+
+std::optional<std::vector<PeerStatus>> parsePeerStatuses(const std::shared_ptr<core::logging::Logger> &logger, const std::string &entity, const utils::Identifier &id) {
+  try {
+    rapidjson::Document root;
+    rapidjson::ParseResult ok = root.Parse(entity.c_str());
+    if (!ok) {
+      std::stringstream ss;
+      ss << "Failed to parse archive lens stack from JSON string with reason: "
+          << rapidjson::GetParseError_En(ok.Code())
+          << " at offset " << ok.Offset();
+
+      throw Exception(ExceptionType::GENERAL_EXCEPTION, ss.str());
+    }
+
+    std::vector<PeerStatus> peer_statuses;
+    if (!root.HasMember("peers") || !root["peers"].IsArray() || root["peers"].Size() <= 0) {
+      logger->log_debug("Peers is either not a member or is empty. String to analyze: {}", entity);
+      return peer_statuses;

Review Comment:
   I think in this case this is not an error because we received a valid json response, but it may be an issue on the peer's side, or it may not add the peers if there are none at the moment. I can change the debug log to a warning as it may be suspicious.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org