You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/06/14 13:30:19 UTC

Review Request 60084: Send information about agentEnv only if it changed.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60084/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.


Bugs: AMBARI-21245
    https://issues.apache.org/jira/browse/AMBARI-21245


Repository: ambari


Description
-------

Currently the information about agent (umask, processes, links, mounts) is
send with heartbeats.

Move to sending via a separate endpoint /reports/host_status and send it only
once its value changed.


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 4cef88b 
  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 3d480ca 
  ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py d0f6801 
  ambari-agent/src/main/python/ambari_agent/Constants.py 8fafca1 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 2350504 
  ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py e54c0c1 
  ambari-agent/src/main/python/ambari_agent/HostInfo.py 4b7bfd7 
  ambari-agent/src/main/python/ambari_agent/HostStatusReporter.py PRE-CREATION 
  ambari-agent/src/main/python/ambari_agent/InitializerModule.py 88c8b91 
  ambari-agent/src/main/python/ambari_agent/Register.py 4c4bf32 
  ambari-agent/src/main/python/ambari_agent/Utils.py de073bb 
  ambari-agent/src/main/python/ambari_agent/main.py a1a98e8 
  ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 9d57261 


Diff: https://reviews.apache.org/r/60084/diff/1/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 60084: Send information about agentEnv only if it changed.

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60084/#review177991
-----------------------------------------------------------


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Червень 14, 2017, 1:30 після полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60084/
> -----------------------------------------------------------
> 
> (Updated Червень 14, 2017, 1:30 після полудня)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21245
>     https://issues.apache.org/jira/browse/AMBARI-21245
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently the information about agent (umask, processes, links, mounts) is
> send with heartbeats.
> 
> Move to sending via a separate endpoint /reports/host_status and send it only
> once its value changed.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 4cef88b 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 3d480ca 
>   ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py d0f6801 
>   ambari-agent/src/main/python/ambari_agent/Constants.py 8fafca1 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 2350504 
>   ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py e54c0c1 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 4b7bfd7 
>   ambari-agent/src/main/python/ambari_agent/HostStatusReporter.py PRE-CREATION 
>   ambari-agent/src/main/python/ambari_agent/InitializerModule.py 88c8b91 
>   ambari-agent/src/main/python/ambari_agent/Register.py 4c4bf32 
>   ambari-agent/src/main/python/ambari_agent/Utils.py de073bb 
>   ambari-agent/src/main/python/ambari_agent/main.py a1a98e8 
>   ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 9d57261 
> 
> 
> Diff: https://reviews.apache.org/r/60084/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>