[jira] [Commented] (AMBARI-18962) Make check_package_condition in script.py overridable by services in stacks

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-18962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688254#comment-15688254 ] 

Hadoop QA commented on AMBARI-18962:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12840094/AMBARI-18962.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/9362//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/9362//console

This message is automatically generated.

> Make check_package_condition in script.py overridable by services in stacks
> ---------------------------------------------------------------------------
>
>                 Key: AMBARI-18962
>                 URL: https://issues.apache.org/jira/browse/AMBARI-18962
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: trunk, 2.5.0
>            Reporter: Di Li
>            Assignee: Di Li
>         Attachments: AMBARI-18962.patch
>
>
> check_package_condition method in script.py was added via AMBARI-14739 to make the conditionally installing RPMs controlled jointly by metainfo.xml and functions defined in package_conditions.py.  For example, with the following metainfo.xml section. The package_conditions.py has the should_install_ams_collector function implementation.
>             <package>
>               <name>ambari-metrics-collector</name>
>               <skipUpgrade>true</skipUpgrade>
>               <condition>should_install_ams_collector</condition>
>             </package>
> The issue is that this is not easily extendable by services extensions (installed via mpack), as any third party service needs to add functions to package_conditions.py in resource_management library.
> This JIRA proposes to make check_package_condition overwritable at the service level ( by changing it from a static method to a instance method).
> Then each service can still maintain the metainfo.xml section, while implement its own check_package_condition that pulls in its own package_condition util.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)