You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/12/01 21:46:33 UTC

[GitHub] [helix] xyuanlu commented on a change in pull request #1560: fix test Helix-rest testAddConfigFields

xyuanlu commented on a change in pull request #1560:
URL: https://github.com/apache/helix/pull/1560#discussion_r533742079



##########
File path: helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java
##########
@@ -224,7 +224,7 @@ public void testGetClusterTopologyAndFaultZoneMap() throws IOException {
   @Test(dependsOnMethods = "testGetClusterTopologyAndFaultZoneMap")
   public void testAddConfigFields() throws IOException {
     System.out.println("Start test :" + TestHelper.getTestMethodName());
-    String cluster = _clusters.iterator().next();
+    String cluster = "TestCluster_1";

Review comment:
       TFTR. I think adding more description for these clusters might be a better option here. Let me update. 
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org