You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2012/09/24 23:28:07 UTC
[jira] [Created] (SOLR-3883) distributed indexing forwards
non-applicable request params
Yonik Seeley created SOLR-3883:
----------------------------------
Summary: distributed indexing forwards non-applicable request params
Key: SOLR-3883
URL: https://issues.apache.org/jira/browse/SOLR-3883
Project: Solr
Issue Type: Bug
Components: SolrCloud
Reporter: Yonik Seeley
Priority: Blocker
Fix For: 4.0
Including all of the original request params can cause really undesirable stuff to happen.
Reported by Dan Sutton:
http://find.searchhub.org/document/c21c27f20e115ce9
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3883) distributed indexing forwards
non-applicable request params
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463467#comment-13463467 ]
Mark Miller commented on SOLR-3883:
-----------------------------------
I think NOW could probably be considered it's own separate issue. I think we should get this change in. Anything I still may be missing?
> distributed indexing forwards non-applicable request params
> -----------------------------------------------------------
>
> Key: SOLR-3883
> URL: https://issues.apache.org/jira/browse/SOLR-3883
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Yonik Seeley
> Assignee: Mark Miller
> Priority: Blocker
> Fix For: 4.0
>
> Attachments: SOLR-3883.patch
>
>
> Including all of the original request params can cause really undesirable stuff to happen.
> Reported by Dan Sutton:
> http://find.searchhub.org/document/c21c27f20e115ce9
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3883) distributed indexing forwards
non-applicable request params
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463389#comment-13463389 ]
Yonik Seeley commented on SOLR-3883:
------------------------------------
Yeah, I guess commit params are already handled within the command - no need for request params.
Is this also the case for commitWithin on adds, deletes, deleteByQuery?
> distributed indexing forwards non-applicable request params
> -----------------------------------------------------------
>
> Key: SOLR-3883
> URL: https://issues.apache.org/jira/browse/SOLR-3883
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Yonik Seeley
> Priority: Blocker
> Fix For: 4.0
>
> Attachments: SOLR-3883.patch
>
>
> Including all of the original request params can cause really undesirable stuff to happen.
> Reported by Dan Sutton:
> http://find.searchhub.org/document/c21c27f20e115ce9
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3883) distributed indexing forwards
non-applicable request params
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated SOLR-3883:
------------------------------
Attachment: SOLR-3883.patch
Here is an initial patch that only pass UPDATE_CHAIN - no handling of NOW.
> distributed indexing forwards non-applicable request params
> -----------------------------------------------------------
>
> Key: SOLR-3883
> URL: https://issues.apache.org/jira/browse/SOLR-3883
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Yonik Seeley
> Priority: Blocker
> Fix For: 4.0
>
> Attachments: SOLR-3883.patch
>
>
> Including all of the original request params can cause really undesirable stuff to happen.
> Reported by Dan Sutton:
> http://find.searchhub.org/document/c21c27f20e115ce9
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3883) distributed indexing forwards
non-applicable request params
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller resolved SOLR-3883.
-------------------------------
Resolution: Fixed
Okay, barring further feedback from yonik, I'm calling this resolved. We can open a new issue to consider how we want to handle NOW values with distrib indexing.
> distributed indexing forwards non-applicable request params
> -----------------------------------------------------------
>
> Key: SOLR-3883
> URL: https://issues.apache.org/jira/browse/SOLR-3883
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Yonik Seeley
> Assignee: Mark Miller
> Priority: Blocker
> Fix For: 4.0, 5.0
>
> Attachments: SOLR-3883.patch
>
>
> Including all of the original request params can cause really undesirable stuff to happen.
> Reported by Dan Sutton:
> http://find.searchhub.org/document/c21c27f20e115ce9
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3883) distributed indexing forwards
non-applicable request params
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated SOLR-3883:
------------------------------
Fix Version/s: 5.0
> distributed indexing forwards non-applicable request params
> -----------------------------------------------------------
>
> Key: SOLR-3883
> URL: https://issues.apache.org/jira/browse/SOLR-3883
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Yonik Seeley
> Assignee: Mark Miller
> Priority: Blocker
> Fix For: 4.0, 5.0
>
> Attachments: SOLR-3883.patch
>
>
> Including all of the original request params can cause really undesirable stuff to happen.
> Reported by Dan Sutton:
> http://find.searchhub.org/document/c21c27f20e115ce9
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3883) distributed indexing forwards
non-applicable request params
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462342#comment-13462342 ]
Yonik Seeley commented on SOLR-3883:
------------------------------------
First guess is that it's probably safer/easier to add params we know we need rather than remove params that could do things we don't want? It just seems like that as we add new methods of creating documents in the future, "dangerous" params could proliferate. Seems like it may be easier to enumerate those params that are necessary/desirable for updates.
Brainstorming off the top of my head:
- Params for updates: commitWithin, NOW?
- Params for commits: softCommit, waitSearcher?
> distributed indexing forwards non-applicable request params
> -----------------------------------------------------------
>
> Key: SOLR-3883
> URL: https://issues.apache.org/jira/browse/SOLR-3883
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Yonik Seeley
> Priority: Blocker
> Fix For: 4.0
>
>
> Including all of the original request params can cause really undesirable stuff to happen.
> Reported by Dan Sutton:
> http://find.searchhub.org/document/c21c27f20e115ce9
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3883) distributed indexing forwards
non-applicable request params
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463502#comment-13463502 ]
Mark Miller commented on SOLR-3883:
-----------------------------------
I've committed the work so far.
> distributed indexing forwards non-applicable request params
> -----------------------------------------------------------
>
> Key: SOLR-3883
> URL: https://issues.apache.org/jira/browse/SOLR-3883
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Yonik Seeley
> Assignee: Mark Miller
> Priority: Blocker
> Fix For: 4.0, 5.0
>
> Attachments: SOLR-3883.patch
>
>
> Including all of the original request params can cause really undesirable stuff to happen.
> Reported by Dan Sutton:
> http://find.searchhub.org/document/c21c27f20e115ce9
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3883) distributed indexing forwards
non-applicable request params
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463411#comment-13463411 ]
Mark Miller commented on SOLR-3883:
-----------------------------------
bq. I suppose not
I take that back - looking further, it seems all ways commitWithin can come in, it gets set on the update command, and our update command distributor then respects sending them on.
> distributed indexing forwards non-applicable request params
> -----------------------------------------------------------
>
> Key: SOLR-3883
> URL: https://issues.apache.org/jira/browse/SOLR-3883
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Yonik Seeley
> Priority: Blocker
> Fix For: 4.0
>
> Attachments: SOLR-3883.patch
>
>
> Including all of the original request params can cause really undesirable stuff to happen.
> Reported by Dan Sutton:
> http://find.searchhub.org/document/c21c27f20e115ce9
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3883) distributed indexing forwards
non-applicable request params
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462247#comment-13462247 ]
Mark Miller commented on SOLR-3883:
-----------------------------------
Per had brought this up as a possible issue in the past, but it was tied up in an issue with a lot of other stuff.
Was trying to avoid having to guess everything that should go, but looks like the reverse may be worse.
> distributed indexing forwards non-applicable request params
> -----------------------------------------------------------
>
> Key: SOLR-3883
> URL: https://issues.apache.org/jira/browse/SOLR-3883
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Yonik Seeley
> Priority: Blocker
> Fix For: 4.0
>
>
> Including all of the original request params can cause really undesirable stuff to happen.
> Reported by Dan Sutton:
> http://find.searchhub.org/document/c21c27f20e115ce9
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (SOLR-3883) distributed indexing forwards
non-applicable request params
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller reassigned SOLR-3883:
---------------------------------
Assignee: Mark Miller
> distributed indexing forwards non-applicable request params
> -----------------------------------------------------------
>
> Key: SOLR-3883
> URL: https://issues.apache.org/jira/browse/SOLR-3883
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Yonik Seeley
> Assignee: Mark Miller
> Priority: Blocker
> Fix For: 4.0
>
> Attachments: SOLR-3883.patch
>
>
> Including all of the original request params can cause really undesirable stuff to happen.
> Reported by Dan Sutton:
> http://find.searchhub.org/document/c21c27f20e115ce9
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3883) distributed indexing forwards
non-applicable request params
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463397#comment-13463397 ]
Mark Miller commented on SOLR-3883:
-----------------------------------
bq. Is this also the case for commitWithin on adds, deletes, deleteByQuery?
I suppose not - this just covers the commit case. It also covers commitWithin from xml or whatever, but it seems we do also have to worry about the case where it's just a request params on an add or delete.
> distributed indexing forwards non-applicable request params
> -----------------------------------------------------------
>
> Key: SOLR-3883
> URL: https://issues.apache.org/jira/browse/SOLR-3883
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Yonik Seeley
> Priority: Blocker
> Fix For: 4.0
>
> Attachments: SOLR-3883.patch
>
>
> Including all of the original request params can cause really undesirable stuff to happen.
> Reported by Dan Sutton:
> http://find.searchhub.org/document/c21c27f20e115ce9
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3883) distributed indexing forwards
non-applicable request params
Posted by "Commit Tag Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494971#comment-13494971 ]
Commit Tag Bot commented on SOLR-3883:
--------------------------------------
[branch_4x commit] Mark Robert Miller
http://svn.apache.org/viewvc?view=revision&revision=1390274
SOLR-3883: Distributed indexing forwards non-applicable request params.
> distributed indexing forwards non-applicable request params
> -----------------------------------------------------------
>
> Key: SOLR-3883
> URL: https://issues.apache.org/jira/browse/SOLR-3883
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Yonik Seeley
> Assignee: Mark Miller
> Priority: Blocker
> Fix For: 4.0, 5.0
>
> Attachments: SOLR-3883.patch
>
>
> Including all of the original request params can cause really undesirable stuff to happen.
> Reported by Dan Sutton:
> http://find.searchhub.org/document/c21c27f20e115ce9
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3883) distributed indexing forwards
non-applicable request params
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463365#comment-13463365 ]
Mark Miller commented on SOLR-3883:
-----------------------------------
bq. Params for updates: commitWithin, NOW? Params for commits: softCommit, waitSearcher?
I've got to brush up on the NOW param...
I think the commit params are all fine - we build a command from the orig request and then pass that on.
We do need to do UpdateParams.UPDATE_CHAIN, but I am not 100% on what else yet.
> distributed indexing forwards non-applicable request params
> -----------------------------------------------------------
>
> Key: SOLR-3883
> URL: https://issues.apache.org/jira/browse/SOLR-3883
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Yonik Seeley
> Priority: Blocker
> Fix For: 4.0
>
>
> Including all of the original request params can cause really undesirable stuff to happen.
> Reported by Dan Sutton:
> http://find.searchhub.org/document/c21c27f20e115ce9
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org