[GitHub] [flink] zentol commented on a diff in pull request #19444: [FLINK-27206][metrics] Deprecate reflection-based reporter instantiation

[GitBox <gi...@apache.org>]

zentol commented on code in PR #19444:
URL: https://github.com/apache/flink/pull/19444#discussion_r853907099


##########
flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java:
##########
@@ -67,8 +67,8 @@ public class MetricOptions {
                                     + " any of the names in the list will be started. Otherwise, all reporters that could be found in"
                                     + " the configuration will be started.");
 
-    @Documentation.SuffixOption(NAMED_REPORTER_CONFIG_PREFIX)
-    @Documentation.Section(value = Documentation.Sections.METRIC_REPORTERS, position = 1)
+    /** @deprecated use {@link MetricOptions#REPORTER_FACTORY_CLASS} instead. */
+    @Deprecated
     public static final ConfigOption<String> REPORTER_CLASS =

Review Comment:
   they are both deprecated now, and are effectively the same thing. I think the current path is fine; someone using `METRICS_REPORTER_CLASS_SUFFIX` is lead to `REPORTER_CLASS`, which then leads to `REPORTER_FACTORY_CLASS`.
   Sure, we could remove 1 jump, but I don't think we'd really get anything out of it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org