You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2019/11/03 04:38:54 UTC
[spark] branch branch-2.4 updated: [SPARK-24152][R][TESTS] Disable
check-cran from run-tests.sh
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-2.4 by this push:
new 4587ad6 [SPARK-24152][R][TESTS] Disable check-cran from run-tests.sh
4587ad6 is described below
commit 4587ad65a9fd287da67991566e1006b2058cc64f
Author: Dongjoon Hyun <dh...@apple.com>
AuthorDate: Sat Nov 2 21:37:40 2019 -0700
[SPARK-24152][R][TESTS] Disable check-cran from run-tests.sh
### What changes were proposed in this pull request?
This PR aims to remove `check-cran` from `run-tests.sh`.
We had better add an independent Jenkins job to run `check-cran`.
### Why are the changes needed?
CRAN instability has been a blocker for our daily dev process.
The following simple check causes consecutive failures in 4 of 9 Jenkins
jobs + PR builder.
```
* checking CRAN incoming feasibility ...Error in
.check_package_CRAN_incoming(pkgdir) :
dims [product 24] do not match the length of object [0]
```
- spark-branch-2.4-test-sbt-hadoop-2.6
- spark-branch-2.4-test-sbt-hadoop-2.7
- spark-master-test-sbt-hadoop-2.7
- spark-master-test-sbt-hadoop-3.2
- PRBuilder
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
Currently, PR builder is failing due to the above issue. This PR should pass the Jenkins.
Closes #26375 from dongjoon-hyun/SPARK-24152.
Authored-by: Dongjoon Hyun <dh...@apple.com>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
(cherry picked from commit 91d990162f13acde546d01e1163ed3e898cbf9a7)
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
R/run-tests.sh | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/R/run-tests.sh b/R/run-tests.sh
index 86bd8aa..27537bf 100755
--- a/R/run-tests.sh
+++ b/R/run-tests.sh
@@ -32,8 +32,10 @@ NUM_TEST_WARNING="$(grep -c -e 'Warnings ----------------' $LOGFILE)"
CRAN_CHECK_LOG_FILE=$FWDIR/cran-check.out
rm -f $CRAN_CHECK_LOG_FILE
-NO_TESTS=1 NO_MANUAL=1 $FWDIR/check-cran.sh 2>&1 | tee -a $CRAN_CHECK_LOG_FILE
-FAILED=$((PIPESTATUS[0]||$FAILED))
+# SPARK-24152 We will add this test back as a separate Jenkins job
+# NO_TESTS=1 NO_MANUAL=1 $FWDIR/check-cran.sh 2>&1 | tee -a $CRAN_CHECK_LOG_FILE
+# FAILED=$((PIPESTATUS[0]||$FAILED))
+touch $CRAN_CHECK_LOG_FILE
NUM_CRAN_WARNING="$(grep -c WARNING$ $CRAN_CHECK_LOG_FILE)"
NUM_CRAN_ERROR="$(grep -c ERROR$ $CRAN_CHECK_LOG_FILE)"
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org