You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/28 21:51:40 UTC

[GitHub] [incubator-nuttx] macman88 opened a new pull request #404: Battery monitor support

macman88 opened a new pull request #404: Battery monitor support
URL: https://github.com/apache/incubator-nuttx/pull/404
 
 
   This PR adds a driver for the BQ769x0 battery monitor IC.  As there were no existing driver types that were a good fit for this device, a new battery monitor driver type was also added.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] macman88 commented on a change in pull request #404: Battery monitor support

Posted by GitBox <gi...@apache.org>.

macman88 commented on a change in pull request #404: Battery monitor support
URL: https://github.com/apache/incubator-nuttx/pull/404#discussion_r385969863
 
 

 ##########
 File path: drivers/power/battery_monitor.c
 ##########
 @@ -0,0 +1,367 @@
+/****************************************************************************
+ * drivers/power/battery_monitor.c
+ * Upper-half, character driver for battery manager & monitor ICs.
+ *
+ *   Copyright (C) 2019, 2020 2G Engineering. All rights reserved.
+ *   Author: Josh Lange <jl...@2g-eng.com>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in
+ *    the documentation and/or other materials provided with the
+ *    distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ *    used to endorse or promote products derived from this software
+ *    without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/
+
 
 Review comment:
   OK, I've updated the new files to have the Apache license.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #404: Battery monitor support

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #404: Battery monitor support
URL: https://github.com/apache/incubator-nuttx/pull/404#discussion_r385948660

##########
File path: drivers/power/battery_monitor.c
##########
@@ -0,0 +1,367 @@
+/****************************************************************************
+ * drivers/power/battery_monitor.c
+ * Upper-half, character driver for battery manager & monitor ICs.
+ *
+ * Copyright (C) 2019, 2020 2G Engineering. All rights reserved.
+ * Author: Josh Lange <jl...@2g-eng.com>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/
+

Review comment:
With your permission, I could make these changes for you. All new files have to have Apache 2.0 licenses in the header (with not copyright info). I don't mind making the change, but since you claim a copyright, I cannot.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo merged pull request #404: Battery monitor support

Posted by GitBox <gi...@apache.org>.

patacongo merged pull request #404: Battery monitor support
URL: https://github.com/apache/incubator-nuttx/pull/404
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #404: Battery monitor support

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #404: Battery monitor support
URL: https://github.com/apache/incubator-nuttx/pull/404#discussion_r385947633

Review comment:
All new files are required to have Apache 2.0 headers (copy from sched/sched/sched_getcpu.d). Sorry, its Apache rules. The other, existing files will be dealt with in the near future.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services