[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20780: fix: unexpected commit causes pytest failure

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #20780:
URL: https://github.com/apache/superset/pull/20780#discussion_r925129814


##########
tests/integration_tests/sqla_models_tests.py:
##########
@@ -472,8 +472,6 @@ def test_fetch_metadata_for_updated_virtual_table(self):
         assert VIRTUAL_TABLE_STRING_TYPES[backend].match(cols["mycase"].type)
         assert cols["expr"].expression == "case when 1 then 1 else 0 end"
 
-        db.session.delete(table)

Review Comment:
   The table is not persistent. (456L)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org