You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/07 19:03:06 UTC
[GitHub] [helix] pkuwm opened a new issue #1232: Stoppable rest response is empty because of instance check exception
pkuwm opened a new issue #1232:
URL: https://github.com/apache/helix/issues/1232
**Describe the bug**
Health check stoppable responds with empty hostname
**To Reproduce**
Turn off the cluster config: "PERSIST_INTERMEDIATE_ASSIGNMENT": "false"
Issue REST request: `/namespaces/<namespace>/clusters/<cluster>/instances?command=stoppable -d ' {"instances": ["instance"], "selection_base": "zone_based", "max_instance": "2", "customized_values": "{}"}' -H "Content-Type: application/json"`
Response has empty contents:
```
{
"instance_stoppable_parallel" : [ ],
"instance_not_stoppable_with_reasons" : { }
}
```
**Expected behavior**
```
{
"instance_stoppable_parallel" : [ "instance" ],
"instance_not_stoppable_with_reasons" : { }
}
```
**Additional context**
"PERSIST_INTERMEDIATE_ASSIGNMENT" needs to be turned on so REST API could check the instance is already in stable state: IS matches EV, as a condition of an instance stoppable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on issue #1232: Stoppable rest response is empty because of instance check exception
Posted by GitBox <gi...@apache.org>.
pkuwm commented on issue #1232:
URL: https://github.com/apache/helix/issues/1232#issuecomment-679288631
Add formatted reason of instance check to API response so users have a clear idea of the reason if PERSIST_INTERMEDIATE_ASSIGNMENT is not turned on.
```
curl -XPOST http://localhost:8100/admin/v2/namespaces/namespacce/clusters/cluster/instances\?command\=stoppable -d ' {"instances": ["instance"], "selection_base": "zone_based", "max_instance": "2", "customized_values": "{}"}' -H "Content-Type: application/json"
{
"instance_stoppable_parallel" : [ ],
"instance_not_stoppable_with_reasons" : {
"instance" : [ "HELIX:INVALID_CONFIG" ]
}
}
```
Server log will have the reason logged: Cluster config PERSIST_INTERMEDIATE_ASSIGNMENT is not turned on, which is required for instance stability check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm closed issue #1232: Stoppable rest response is empty because of instance check exception
Posted by GitBox <gi...@apache.org>.
pkuwm closed issue #1232:
URL: https://github.com/apache/helix/issues/1232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org