You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@netbeans.apache.org by lk...@apache.org on 2020/12/20 06:02:26 UTC
[netbeans] branch master updated: NETBEANS-5034 fix wrong javadoc
error hint
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new a5c6224 NETBEANS-5034 fix wrong javadoc error hint
a5c6224 is described below
commit a5c6224f82c3f6bf9311fc7abddd65c68fde276b
Author: Jakub Herkel <j....@uniq.sk>
AuthorDate: Tue Nov 17 16:57:19 2020 +0100
NETBEANS-5034 fix wrong javadoc error hint
---
.../src/org/netbeans/modules/javadoc/hints/Analyzer.java | 2 +-
.../org/netbeans/modules/javadoc/hints/Analyzer2Test.java | 15 +++++++++++++++
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/java/javadoc/src/org/netbeans/modules/javadoc/hints/Analyzer.java b/java/javadoc/src/org/netbeans/modules/javadoc/hints/Analyzer.java
index 5c92f69..94772b2 100644
--- a/java/javadoc/src/org/netbeans/modules/javadoc/hints/Analyzer.java
+++ b/java/javadoc/src/org/netbeans/modules/javadoc/hints/Analyzer.java
@@ -633,7 +633,7 @@ final class Analyzer extends DocTreePathScanner<Void, List<ErrorDescription>> {
if (t == null) {
errors.add(ErrorDescriptionFactory.forSpan(ctx, start, end, TAG_UNKNOWN(treeName)));
} else {
- if (!t.hasOptionalEndTag() && !isVoid(t)) {
+ if (!isVoid(t)) {
tagStack.push(node);
}
}
diff --git a/java/javadoc/test/unit/src/org/netbeans/modules/javadoc/hints/Analyzer2Test.java b/java/javadoc/test/unit/src/org/netbeans/modules/javadoc/hints/Analyzer2Test.java
index d5a5d03..477c0ac 100644
--- a/java/javadoc/test/unit/src/org/netbeans/modules/javadoc/hints/Analyzer2Test.java
+++ b/java/javadoc/test/unit/src/org/netbeans/modules/javadoc/hints/Analyzer2Test.java
@@ -346,4 +346,19 @@ public class Analyzer2Test extends NbTestCase {
.run(JavadocHint.class)
.assertContainsWarnings("2:3-2:11:warning:End Tag Missing: </strong>");
}
+
+ public void testOptionalEndTag() throws Exception {
+ HintTest.create()
+ .input(
+ "package test;\n" +
+ "/**\n" +
+ " * <ul><li>One<li>Two</li></ul>\n" +
+ " */\n" +
+ "class Zima {\n" +
+ "}\n")
+ .preference(AVAILABILITY_KEY + true, true)
+ .preference(SCOPE_KEY, "private")
+ .run(JavadocHint.class)
+ .assertWarnings();
+ }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@netbeans.apache.org
For additional commands, e-mail: commits-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists