You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by cestella <gi...@git.apache.org> on 2018/03/06 16:22:37 UTC
[GitHub] metron pull request #949: METRON-1471: Migrate shuffle connections to local ...
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/949
METRON-1471: Migrate shuffle connections to local or shuffle
## Contributor Comments
Currently, we use shuffle groupings when we do not want to group by field. We should, instead, use local or shuffle groupings.
Manual tests should include ensuring data continues to flow as before.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron local_or_shuffle_indexing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/949.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #949
----
commit 0ab26fa172a90eaf8eb441c8c085308649efdfb9
Author: cstella <ce...@...>
Date: 2018-03-06T16:18:57Z
Updating the rest of the topologies to prefer local or shuffle over shuffle
----
---
[GitHub] metron pull request #949: METRON-1471: Migrate shuffle connections to local ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/949
---
[GitHub] metron issue #949: METRON-1471: Migrate shuffle connections to local or shuf...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/949
+1 thanks!
---
[GitHub] metron issue #949: METRON-1471: Migrate shuffle connections to local or shuf...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/949
There are also shuffle groupings in the enrichment and profiler topologies. Do we want to update those too?
---
[GitHub] metron issue #949: METRON-1471: Migrate shuffle connections to local or shuf...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/949
@merrimanr Ah, I had forgotten to merge in master yesterday afternoon. There should be no more shuffles in any of the topologies.
---
[GitHub] metron pull request #949: METRON-1471: Migrate shuffle connections to local ...
Posted by cestella <gi...@git.apache.org>.
Github user cestella closed the pull request at:
https://github.com/apache/metron/pull/949
---
[GitHub] metron issue #949: METRON-1471: Migrate shuffle connections to local or shuf...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/949
@merrimanr As of now, there should be no more SHUFFLE groupings in enrichments, but I'll change the profiler for sure.
---
[GitHub] metron pull request #949: METRON-1471: Migrate shuffle connections to local ...
Posted by cestella <gi...@git.apache.org>.
GitHub user cestella reopened a pull request:
https://github.com/apache/metron/pull/949
METRON-1471: Migrate shuffle connections to local or shuffle
## Contributor Comments
Currently, we use shuffle groupings when we do not want to group by field. We should, instead, use local or shuffle groupings.
Manual tests should include ensuring data continues to flow as before.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron local_or_shuffle_indexing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/949.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #949
----
commit 0ab26fa172a90eaf8eb441c8c085308649efdfb9
Author: cstella <ce...@...>
Date: 2018-03-06T16:18:57Z
Updating the rest of the topologies to prefer local or shuffle over shuffle
commit 82a7c823ab27441ddda5c043dee3cef8aa8f03be
Author: cstella <ce...@...>
Date: 2018-03-08T14:25:19Z
Merge branch 'master' into local_or_shuffle_indexing
commit 2d3a7f68dc7570ca1a44b9b6a4b2880292e18824
Author: cstella <ce...@...>
Date: 2018-03-08T14:26:48Z
Fixed profiler
----
---
[GitHub] metron issue #949: METRON-1471: Migrate shuffle connections to local or shuf...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/949
I still see a SHUFFLE grouping (spout -> enrichmentSplit) in the legacy enrichment topology flux file. Maybe we end up switching to the new enrichment topology so not important in that case.
---