You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/24 03:44:54 UTC
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #20257: Fix Oracle pagination and sorting/grouping problem: add ‘order by’/'group by' of the subquery to its outer statement if the subquery selects oracle rownum
strongduanmu commented on code in PR #20257:
URL: https://github.com/apache/shardingsphere/pull/20257#discussion_r1002860735
##########
infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/OracleSelectStatementContextDialect.java:
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.binder.statement.dml;
+
+import java.util.Collection;
+import java.util.Optional;
+
+import org.apache.shardingsphere.infra.binder.segment.select.groupby.GroupByContext;
+import org.apache.shardingsphere.infra.binder.segment.select.orderby.OrderByContext;
+import org.apache.shardingsphere.infra.binder.segment.select.projection.ProjectionsContext;
+import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.column.ColumnSegment;
+import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr.BinaryOperationExpression;
+import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr.ExpressionSegment;
+import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.predicate.WhereSegment;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.dml.OracleSelectStatement;
+
+/**
+ * Oracle Select SQL statement context dialect.
+ */
+public final class OracleSelectStatementContextDialect implements SelectStatementContextDialect {
Review Comment:
Can logic from OracleSelectStatementContextDialect be merged into SelectStatementContext ?
##########
infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/select/projection/ProjectionUtil.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.binder.segment.select.projection;
+
+import java.util.Collection;
+import java.util.LinkedList;
+
+import org.apache.shardingsphere.infra.binder.segment.select.projection.impl.DerivedProjection;
+import org.apache.shardingsphere.infra.binder.segment.select.projection.impl.ShorthandProjection;
+
+/**
+ * projection util.
+ */
+public class ProjectionUtil {
+
+ /**
+ * expand projection, such as ShorthandProjection.
+ * @param projection the projection to expand
+ * @return expanded projections
+ */
+ public static Collection<Projection> expandProjection(final Projection projection) {
Review Comment:
Can we get expand projections by projection context?
##########
infra/binder/src/test/java/org/apache/shardingsphere/infra/binder/statement/impl/SelectStatementContextTest.java:
##########
@@ -602,4 +604,33 @@ private ProjectionSegment getColumnProjectionSegmentWithoutOwner(final boolean h
columnProjectionSegment.setAlias(new AliasSegment(0, 0, new IdentifierValue(hasAlias ? "n" : null)));
return columnProjectionSegment;
}
+
+ @Test
+ public void assertGroupbyWithPagingForOracle() {
+ // select rownum , city, count(1) from t_user group by city
+ ProjectionsSegment innerProjections = new ProjectionsSegment(0, 0);
+ ColumnProjectionSegment rownumProjectionSegment = new ColumnProjectionSegment(new ColumnSegment(0, 0, new IdentifierValue("ROWNUM")));
+ rownumProjectionSegment.setAlias(new AliasSegment(0, 0, new IdentifierValue("pagerow_")));
+ innerProjections.getProjections().add(rownumProjectionSegment);
+ ColumnSegment cityColumnSegment = new ColumnSegment(0, 0, new IdentifierValue("city"));
+ innerProjections.getProjections().add(new ColumnProjectionSegment(cityColumnSegment));
+ innerProjections.getProjections().add(new AggregationProjectionSegment(0, 0, AggregationType.COUNT, "(1)"));
+ OracleSelectStatement innerSelectStatement = new OracleSelectStatement();
+ innerSelectStatement.setProjections(innerProjections);
+ innerSelectStatement.setFrom(new SimpleTableSegment(new TableNameSegment(0, 0, new IdentifierValue("t_user"))));
+ innerSelectStatement.setGroupBy(new GroupBySegment(0, 0, Arrays.asList(new ColumnOrderByItemSegment(cityColumnSegment, OrderDirection.ASC))));
+
Review Comment:
Please remove this useless black line.
##########
infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/SelectStatementContextDialect.java:
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.binder.statement.dml;
+
+import org.apache.shardingsphere.infra.binder.segment.select.groupby.GroupByContext;
+import org.apache.shardingsphere.infra.binder.segment.select.orderby.OrderByContext;
+import org.apache.shardingsphere.infra.binder.segment.select.projection.ProjectionsContext;
+
+/**
+ * Select SQL statement context dialect.
+ */
+public interface SelectStatementContextDialect {
+
+ /**
+ * update GroupbyContext.
+ * @param groupByContext groupByContext
+ */
+ default void updateGroupbyContext(final GroupByContext groupByContext) {
+
Review Comment:
Please remove useless blank line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org