You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2013/11/17 08:13:22 UTC

[jira] [Commented] (THRIFT-2260) Thrift imposes unneeded dependency on commons-lang3

    [ https://issues.apache.org/jira/browse/THRIFT-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824766#comment-13824766 ] 

Hudson commented on THRIFT-2260:
--------------------------------

SUCCESS: Integrated in Thrift #942 (See [https://builds.apache.org/job/Thrift/942/])
THRIFT-2260 java: Thrift imposes unneeded dependency on commons-lang3 (roger: rev 3da1c9025b77f5ca3ba4c296b8ab3089235b9c3b)
* debian/control
* lib/java/build.xml
* contrib/Vagrantfile
* lib/java/build.properties
* compiler/cpp/src/generate/t_java_generator.cc


> Thrift imposes unneeded dependency on commons-lang3
> ---------------------------------------------------
>
>                 Key: THRIFT-2260
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2260
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Compiler
>    Affects Versions: 0.9.1
>            Reporter: Andrew Gaul
>            Assignee: Roger Meier
>            Priority: Minor
>             Fix For: 0.9.2
>
>         Attachments: THRIFT-2260.patch
>
>
> Thrift depends on commons-lang3, yet only uses HashCodeBuilder.  We can  rely on the default List.hashCode implementation and remove this 300 KB dependency.  This will prepare the generator for removing the hashcode option and always generating high-quality hash codes.



--
This message was sent by Atlassian JIRA
(v6.1#6144)