You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "jonyangx (via GitHub)" <gi...@apache.org> on 2023/02/19 02:37:58 UTC

[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #3198: [ISSUE #3197]Optimize TopicResponse toString method

jonyangx commented on code in PR #3198:
URL: https://github.com/apache/incubator-eventmesh/pull/3198#discussion_r1111138963


##########
eventmesh-admin/eventmesh-admin-rocketmq/src/main/java/org/apache/eventmesh/admin/rocketmq/response/TopicResponse.java:
##########
@@ -56,8 +56,8 @@ public void setCreatedTime(String createdTime) {
     @Override
     public String toString() {
         StringBuilder sb = new StringBuilder();
-        sb.append("TopicResponse {topic=" + this.topic + ",");
-        sb.append("created_time=" + this.createdTime + "}");
+        sb.append("TopicResponse {topic=").append(this.topic).append(",");
+        sb.append("created_time=").append(this.createdTime).append("}");

Review Comment:
   Suggest merge the code using append method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org