You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/08/26 03:02:33 UTC
[GitHub] [servicecomb-java-chassis] develpoerX opened a new pull request #2531: #scb-2317 change client default connection idle timeout to 30s
develpoerX opened a new pull request #2531:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2531
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #2531: #scb-2317 change client default connection idle timeout to 30s
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2531:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2531#issuecomment-906064570
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2531](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb16bc6) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/b61a2199f333bd2780b514f82cf003c46bc99cd7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b61a219) will **decrease** coverage by `1.54%`.
> The diff coverage is `2.98%`.
> :exclamation: Current head eb16bc6 differs from pull request most recent head abf762e. Consider uploading reports for the commit abf762e to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2531 +/- ##
============================================
- Coverage 79.19% 77.64% -1.55%
Complexity 1419 1419
============================================
Files 1559 1597 +38
Lines 41574 42407 +833
Branches 3470 3569 +99
============================================
+ Hits 32926 32929 +3
- Misses 7158 7986 +828
- Partials 1490 1492 +2
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ecomb/config/center/client/ConfigCenterClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWctY2VudGVyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2NlbnRlci9jbGllbnQvQ29uZmlnQ2VudGVyQ2xpZW50LmphdmE=) | `44.23% <0.00%> (-2.71%)` | :arrow_down: |
| [...c/main/java/org/apache/servicecomb/core/Const.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9Db25zdC5qYXZh) | `0.00% <ø> (ø)` | |
| [.../apache/servicecomb/darklaunch/DarklaunchRule.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvRGFya2xhdW5jaFJ1bGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/servicecomb/darklaunch/DarklaunchRuleItem.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvRGFya2xhdW5jaFJ1bGVJdGVtLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...servicecomb/darklaunch/DarklaunchRuleItemJson.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvRGFya2xhdW5jaFJ1bGVJdGVtSnNvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...che/servicecomb/darklaunch/DarklaunchRuleJson.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvRGFya2xhdW5jaFJ1bGVKc29uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...icecomb/darklaunch/DarklaunchServerListFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvRGFya2xhdW5jaFNlcnZlckxpc3RGaWx0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ache/servicecomb/darklaunch/MicroserviceCache.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvTWljcm9zZXJ2aWNlQ2FjaGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/servicecomb/darklaunch/PolicyType.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvUG9saWN5VHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...servicecomb/darklaunch/oper/AbstractCondition.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvb3Blci9BYnN0cmFjdENvbmRpdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [56 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [094119f...abf762e](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] develpoerX commented on a change in pull request #2531: #scb-2317 change client default connection idle timeout to 30s
Posted by GitBox <gi...@apache.org>.
develpoerX commented on a change in pull request #2531:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2531#discussion_r699883020
##########
File path: service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/config/ServiceRegistryConfigBuilder.java
##########
@@ -144,19 +144,9 @@ public int getIdleConnectionTimeout() {
DynamicIntProperty property =
DynamicPropertyFactory.getInstance()
.getIntProperty("servicecomb.service.registry.client.timeout.idle",
- ServiceRegistryConfig.DEFAULT_TIMEOUT_IN_SECONDS * 2);
+ ServiceRegistryConfig.DEFAULT_TIMEOUT_IN_SECONDS);
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2531: #scb-2317 change client default connection idle timeout to 30s
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2531:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #2531: #scb-2317 change client default connection idle timeout to 30s
Posted by GitBox <gi...@apache.org>.
liubao68 commented on pull request #2531:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2531#issuecomment-910050079
Maybe set server idle timeout to 120s and client idle timeout to 60s is better.
However, if users run java chassis in tomcat, the default timeout is 60s, so we keep default client idle timeout to 30s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2531: #scb-2317 change client default connection idle timeout to 30s
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2531:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2531#issuecomment-906064570
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2531](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b5515bf) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/b61a2199f333bd2780b514f82cf003c46bc99cd7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b61a219) will **decrease** coverage by `1.57%`.
> The diff coverage is `5.57%`.
> :exclamation: Current head b5515bf differs from pull request most recent head fea94d1. Consider uploading reports for the commit fea94d1 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2531 +/- ##
============================================
- Coverage 79.19% 77.62% -1.58%
Complexity 1419 1419
============================================
Files 1559 1597 +38
Lines 41574 42426 +852
Branches 3470 3572 +102
============================================
+ Hits 32926 32932 +6
- Misses 7158 8000 +842
- Partials 1490 1494 +4
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ecomb/config/center/client/ConfigCenterClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWctY2VudGVyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2NlbnRlci9jbGllbnQvQ29uZmlnQ2VudGVyQ2xpZW50LmphdmE=) | `44.23% <0.00%> (-2.71%)` | :arrow_down: |
| [...pache/servicecomb/config/kie/client/KieClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWcta2llLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9jbGllbnQvS2llQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ervicecomb/config/kie/client/KieConfigManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWcta2llLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9jbGllbnQvS2llQ29uZmlnTWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../service/center/client/ServiceCenterDiscovery.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9zZXJ2aWNlLWNlbnRlci1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3NlcnZpY2UvY2VudGVyL2NsaWVudC9TZXJ2aWNlQ2VudGVyRGlzY292ZXJ5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...c/main/java/org/apache/servicecomb/core/Const.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9Db25zdC5qYXZh) | `0.00% <ø> (ø)` | |
| [...mb/config/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvblNvdXJjZUltcGwuamF2YQ==) | `48.91% <0.00%> (ø)` | |
| [...icecomb/config/kie/KieConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWtpZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9LaWVDb25maWd1cmF0aW9uU291cmNlSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ervicecomb/edge/core/CommonHttpEdgeDispatcher.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWRnZS9lZGdlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2VkZ2UvY29yZS9Db21tb25IdHRwRWRnZURpc3BhdGNoZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apache/servicecomb/darklaunch/DarklaunchRule.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvRGFya2xhdW5jaFJ1bGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/servicecomb/darklaunch/DarklaunchRuleItem.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvRGFya2xhdW5jaFJ1bGVJdGVtLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [66 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [094119f...fea94d1](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2531: #scb-2317 change client default connection idle timeout to 30s
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2531:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2531: #scb-2317 change client default connection idle timeout to 30s
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2531:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2531#discussion_r696270731
##########
File path: service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/config/ServiceRegistryConfigBuilder.java
##########
@@ -144,19 +144,9 @@ public int getIdleConnectionTimeout() {
DynamicIntProperty property =
DynamicPropertyFactory.getInstance()
.getIntProperty("servicecomb.service.registry.client.timeout.idle",
- ServiceRegistryConfig.DEFAULT_TIMEOUT_IN_SECONDS * 2);
+ ServiceRegistryConfig.DEFAULT_TIMEOUT_IN_SECONDS);
Review comment:
do not change this.
This issue if for servicecomb.rest.client.connection.idleTimeoutInSeconds
and the reason is to keep this time harf of server idle timeout(tomcat, vertx. etc.) to avoid randomly got closed connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2531: #scb-2317 change client default connection idle timeout to 30s
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2531:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2531#issuecomment-906064570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2531: #scb-2317 change client default connection idle timeout to 30s
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2531:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2531#issuecomment-906064570
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2531](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (284c924) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/b61a2199f333bd2780b514f82cf003c46bc99cd7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b61a219) will **decrease** coverage by `1.56%`.
> The diff coverage is `0.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2531 +/- ##
============================================
- Coverage 79.19% 77.63% -1.57%
Complexity 1419 1419
============================================
Files 1559 1597 +38
Lines 41574 42421 +847
Branches 3470 3571 +101
============================================
+ Hits 32926 32934 +8
- Misses 7158 7994 +836
- Partials 1490 1493 +3
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ecomb/config/center/client/ConfigCenterClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWctY2VudGVyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2NlbnRlci9jbGllbnQvQ29uZmlnQ2VudGVyQ2xpZW50LmphdmE=) | `44.23% <0.00%> (-2.71%)` | :arrow_down: |
| [.../apache/servicecomb/darklaunch/DarklaunchRule.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvRGFya2xhdW5jaFJ1bGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/servicecomb/darklaunch/DarklaunchRuleItem.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvRGFya2xhdW5jaFJ1bGVJdGVtLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...servicecomb/darklaunch/DarklaunchRuleItemJson.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvRGFya2xhdW5jaFJ1bGVJdGVtSnNvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...che/servicecomb/darklaunch/DarklaunchRuleJson.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvRGFya2xhdW5jaFJ1bGVKc29uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...icecomb/darklaunch/DarklaunchServerListFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvRGFya2xhdW5jaFNlcnZlckxpc3RGaWx0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ache/servicecomb/darklaunch/MicroserviceCache.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvTWljcm9zZXJ2aWNlQ2FjaGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/servicecomb/darklaunch/PolicyType.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvUG9saWN5VHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...servicecomb/darklaunch/oper/AbstractCondition.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvb3Blci9BYnN0cmFjdENvbmRpdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ache/servicecomb/darklaunch/oper/AndCondition.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL2RhcmtsYXVuY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RhcmtsYXVuY2gvb3Blci9BbmRDb25kaXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [58 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [094119f...284c924](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2531?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2531: #scb-2317 change client default connection idle timeout to 30s
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2531:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2531#issuecomment-906064570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #2531: #scb-2317 change client default connection idle timeout to 30s
Posted by GitBox <gi...@apache.org>.
liubao68 commented on pull request #2531:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2531#issuecomment-910050079
Maybe set server idle timeout to 120s and client idle timeout to 60s is better.
However, if users run java chassis in tomcat, the default timeout is 60s, so we keep default client idle timeout to 30s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] develpoerX commented on a change in pull request #2531: #scb-2317 change client default connection idle timeout to 30s
Posted by GitBox <gi...@apache.org>.
develpoerX commented on a change in pull request #2531:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2531#discussion_r699883020
##########
File path: service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/config/ServiceRegistryConfigBuilder.java
##########
@@ -144,19 +144,9 @@ public int getIdleConnectionTimeout() {
DynamicIntProperty property =
DynamicPropertyFactory.getInstance()
.getIntProperty("servicecomb.service.registry.client.timeout.idle",
- ServiceRegistryConfig.DEFAULT_TIMEOUT_IN_SECONDS * 2);
+ ServiceRegistryConfig.DEFAULT_TIMEOUT_IN_SECONDS);
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org