You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/23 18:42:00 UTC

[GitHub] [maven] Bananeweizen commented on pull request #934: [MNG-7352] org.apache.maven.toolchain.java.JavaToolchainImpl should b…

Bananeweizen commented on PR #934:
URL: https://github.com/apache/maven/pull/934#issuecomment-1364178304

   To me this looks good. Regarding the question how this is used: https://github.com/eclipse-tycho/tycho/blob/4e3f31c4411156c86a8571e353efde898cf258ea/tycho-compiler-plugin/src/main/java/org/eclipse/tycho/compiler/AbstractOsgiCompilerMojo.java#L777 shows Tycho calling `getJavaHome()` on that class, which is not available in the super interface, otherwise we wouldn't need to look at this class.
   I'm not sure whether I should also comment in the Jira issue (is there any transition of Maven projects to Github ongoing or was it always this kind of mixed for issues and pull requests?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org