[GitHub] spark issue #18029: [SPARK-20168] [DStream] Add changes to use kinesis fetch...

[brkyvz <gi...@git.apache.org>]

Github user brkyvz commented on the issue:

    https://github.com/apache/spark/pull/18029
  
    Actually yeah, I like your way.
    
    On Dec 14, 2017 3:08 PM, "yashs360" <no...@github.com> wrote:
    
    > *@yashs360* commented on this pull request.
    > ------------------------------
    >
    > In external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/
    > InitialPosition.scala
    > <https://github.com/apache/spark/pull/18029#discussion_r157086878>:
    >
    > > +import java.util.Date
    > +
    > +import com.amazonaws.services.kinesis.clientlibrary.lib.worker.InitialPositionInStream
    > +
    > +/**
    > + * Trait for Kinesis's InitialPositionInStream.
    > + * This will be overridden by more specific types.
    > + */
    > +sealed trait InitialPosition {
    > +  val initialPositionInStream: InitialPositionInStream
    > +}
    > +
    > +/**
    > + * Case object for Kinesis's InitialPositionInStream.LATEST.
    > + */
    > +case object Latest extends InitialPosition {
    >
    > Hi @brkyvz <https://github.com/brkyvz> , Thanks for the review.
    > Are you suggesting to put everything into a new object. And refer the case
    > objects from the java class methods?
    > In that case is it better to create the objects in Java and expose them
    > directly, since we will have cases where we will need direct access to the
    > case objects/classes (instead of the java methods) like one of the test
    > cases:
    > initialPosition.asInstanceOf[AtTimestamp].timestamp
    >
    > I would create a new branch with the changes and share with you if its
    > fine ?
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/spark/pull/18029#discussion_r157086878>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe-auth/AFACewoTV1GYt4dpddBP_Jsx7cF6AUVjks5tAaprgaJpZM4NfLn->
    > .
    >



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org