You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Wang Jie <wa...@cmss.chinamobile.com> on 2017/03/14 01:23:35 UTC
Review Request 57580: Enhance Kafka Service Check
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57580/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Andrii Tkach, Dmitro Lisnichenko, Jaimin Jetly, Jayush Luniya, and Srimanth Gunturi.
Bugs: AMBARI-20434
https://issues.apache.org/jira/browse/AMBARI-20434
Repository: ambari
Description
-------
Problem:
Kafka Service Check will create the kafka topic only if the topic doesn't exist.
if it exists, Kafka Service Check will return success directly.
After topic is being created, we sense that each time running service check will not reflect the kafka actual state correctly
Suggestion:
Every running kafka service check, delete the existed topic and recreate it.
Diffs
-----
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/service_check.py 0f3a417
ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml 0275358
Diff: https://reviews.apache.org/r/57580/diff/1/
Testing
-------
Done
Thanks,
Wang Jie
Re: Review Request 57580: Enhance Kafka Service Check
Posted by Wang Jie <wa...@cmss.chinamobile.com>.
> On 三月 14, 2017, 9:51 a.m., Dmitro Lisnichenko wrote:
> > Ship It!
Thank you so much for reviewing my patch on reviewboard, and could you commit the patch ? Thanks
- Wang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57580/#review168877
-----------------------------------------------------------
On 三月 14, 2017, 1:23 a.m., Wang Jie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57580/
> -----------------------------------------------------------
>
> (Updated 三月 14, 2017, 1:23 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrii Tkach, Dmitro Lisnichenko, Jaimin Jetly, Jayush Luniya, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-20434
> https://issues.apache.org/jira/browse/AMBARI-20434
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem:
> Kafka Service Check will create the kafka topic only if the topic doesn't exist.
> if it exists, Kafka Service Check will return success directly.
> After topic is being created, we sense that each time running service check will not reflect the kafka actual state correctly
>
> Suggestion:
> Every running kafka service check, delete the existed topic and recreate it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/service_check.py 0f3a417
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml 0275358
>
>
> Diff: https://reviews.apache.org/r/57580/diff/1/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Wang Jie
>
>
Re: Review Request 57580: Enhance Kafka Service Check
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On March 14, 2017, 11:51 a.m., Dmitro Lisnichenko wrote:
> > Ship It!
>
> Wang Jie wrote:
> Thank you so much for reviewing my patch on reviewboard, and could you commit the patch ? Thanks
done
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57580/#review168877
-----------------------------------------------------------
On March 14, 2017, 3:23 a.m., Wang Jie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57580/
> -----------------------------------------------------------
>
> (Updated March 14, 2017, 3:23 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrii Tkach, Dmitro Lisnichenko, Jaimin Jetly, Jayush Luniya, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-20434
> https://issues.apache.org/jira/browse/AMBARI-20434
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem:
> Kafka Service Check will create the kafka topic only if the topic doesn't exist.
> if it exists, Kafka Service Check will return success directly.
> After topic is being created, we sense that each time running service check will not reflect the kafka actual state correctly
>
> Suggestion:
> Every running kafka service check, delete the existed topic and recreate it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/service_check.py 0f3a417
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml 0275358
>
>
> Diff: https://reviews.apache.org/r/57580/diff/1/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Wang Jie
>
>
Re: Review Request 57580: Enhance Kafka Service Check
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57580/#review168877
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On March 14, 2017, 3:23 a.m., Wang Jie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57580/
> -----------------------------------------------------------
>
> (Updated March 14, 2017, 3:23 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrii Tkach, Dmitro Lisnichenko, Jaimin Jetly, Jayush Luniya, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-20434
> https://issues.apache.org/jira/browse/AMBARI-20434
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem:
> Kafka Service Check will create the kafka topic only if the topic doesn't exist.
> if it exists, Kafka Service Check will return success directly.
> After topic is being created, we sense that each time running service check will not reflect the kafka actual state correctly
>
> Suggestion:
> Every running kafka service check, delete the existed topic and recreate it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/service_check.py 0f3a417
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml 0275358
>
>
> Diff: https://reviews.apache.org/r/57580/diff/1/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Wang Jie
>
>
Re: Review Request 57580: Enhance Kafka Service Check
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57580/#review174709
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On May 11, 2017, 2:11 a.m., Wang Jie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57580/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 2:11 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrii Tkach, Dmitro Lisnichenko, Jaimin Jetly, Jayush Luniya, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-20434
> https://issues.apache.org/jira/browse/AMBARI-20434
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem:
> Kafka Service Check will create the kafka topic only if the topic doesn't exist.
> if it exists, Kafka Service Check will return success directly.
> After topic is being created, we sense that each time running service check will not reflect the kafka actual state correctly
>
> Suggestion:
> Every running kafka service check, delete the existed topic and recreate it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/service_check.py 0f3a417
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml 0275358
>
>
> Diff: https://reviews.apache.org/r/57580/diff/1/
>
>
> Testing
> -------
>
> Done
>
>
> File Attachments
> ----------------
>
> AMBARI-20434-1.patch
> https://reviews.apache.org/media/uploaded/files/2017/05/11/299ea8d7-8093-42d9-8a64-ceadcfbea90a__AMBARI-20434-1.patch
>
>
> Thanks,
>
> Wang Jie
>
>
Re: Review Request 57580: Enhance Kafka Service Check
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57580/#review174630
-----------------------------------------------------------
Committed
remote: ambari git commit: AMBARI-20434. Enhance Kafka Service Check. Additional changes (WangJie via dlysnichenko)
To https://git-wip-us.apache.org/repos/asf/ambari.git
242d9e76f9..4b3cbef39e trunk -> trunk
- Dmitro Lisnichenko
On May 11, 2017, 5:11 a.m., Wang Jie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57580/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 5:11 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrii Tkach, Dmitro Lisnichenko, Jaimin Jetly, Jayush Luniya, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-20434
> https://issues.apache.org/jira/browse/AMBARI-20434
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem:
> Kafka Service Check will create the kafka topic only if the topic doesn't exist.
> if it exists, Kafka Service Check will return success directly.
> After topic is being created, we sense that each time running service check will not reflect the kafka actual state correctly
>
> Suggestion:
> Every running kafka service check, delete the existed topic and recreate it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/service_check.py 0f3a417
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml 0275358
>
>
> Diff: https://reviews.apache.org/r/57580/diff/1/
>
>
> Testing
> -------
>
> Done
>
>
> File Attachments
> ----------------
>
> AMBARI-20434-1.patch
> https://reviews.apache.org/media/uploaded/files/2017/05/11/299ea8d7-8093-42d9-8a64-ceadcfbea90a__AMBARI-20434-1.patch
>
>
> Thanks,
>
> Wang Jie
>
>
Re: Review Request 57580: Enhance Kafka Service Check
Posted by Wang Jie <wa...@cmss.chinamobile.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57580/
-----------------------------------------------------------
(Updated 五月 11, 2017, 2:11 a.m.)
Review request for Ambari, Alejandro Fernandez, Andrii Tkach, Dmitro Lisnichenko, Jaimin Jetly, Jayush Luniya, and Srimanth Gunturi.
Bugs: AMBARI-20434
https://issues.apache.org/jira/browse/AMBARI-20434
Repository: ambari
Description
-------
Problem:
Kafka Service Check will create the kafka topic only if the topic doesn't exist.
if it exists, Kafka Service Check will return success directly.
After topic is being created, we sense that each time running service check will not reflect the kafka actual state correctly
Suggestion:
Every running kafka service check, delete the existed topic and recreate it.
Diffs
-----
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/service_check.py 0f3a417
ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml 0275358
Diff: https://reviews.apache.org/r/57580/diff/1/
Testing
-------
Done
File Attachments (updated)
----------------
AMBARI-20434-1.patch
https://reviews.apache.org/media/uploaded/files/2017/05/11/299ea8d7-8093-42d9-8a64-ceadcfbea90a__AMBARI-20434-1.patch
Thanks,
Wang Jie
Re: Review Request 57580: Enhance Kafka Service Check
Posted by Wang Jie <wa...@cmss.chinamobile.com>.
> On 五月 10, 2017, 5:54 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/service_check.py
> > Line 44 (original), 44 (patched)
> > <https://reviews.apache.org/r/57580/diff/1/?file=1662958#file1662958line44>
> >
> > Please make the same changes for ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0
Please see the new attached file AMBARI-20434-1.patch ,thanks
- Wang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57580/#review174515
-----------------------------------------------------------
On 五月 11, 2017, 2:11 a.m., Wang Jie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57580/
> -----------------------------------------------------------
>
> (Updated 五月 11, 2017, 2:11 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrii Tkach, Dmitro Lisnichenko, Jaimin Jetly, Jayush Luniya, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-20434
> https://issues.apache.org/jira/browse/AMBARI-20434
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem:
> Kafka Service Check will create the kafka topic only if the topic doesn't exist.
> if it exists, Kafka Service Check will return success directly.
> After topic is being created, we sense that each time running service check will not reflect the kafka actual state correctly
>
> Suggestion:
> Every running kafka service check, delete the existed topic and recreate it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/service_check.py 0f3a417
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml 0275358
>
>
> Diff: https://reviews.apache.org/r/57580/diff/1/
>
>
> Testing
> -------
>
> Done
>
>
> File Attachments
> ----------------
>
> AMBARI-20434-1.patch
> https://reviews.apache.org/media/uploaded/files/2017/05/11/299ea8d7-8093-42d9-8a64-ceadcfbea90a__AMBARI-20434-1.patch
>
>
> Thanks,
>
> Wang Jie
>
>
Re: Review Request 57580: Enhance Kafka Service Check
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57580/#review174515
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/service_check.py
Line 44 (original), 44 (patched)
<https://reviews.apache.org/r/57580/#comment247670>
Please make the same changes for ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0
- Alejandro Fernandez
On March 14, 2017, 1:23 a.m., Wang Jie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57580/
> -----------------------------------------------------------
>
> (Updated March 14, 2017, 1:23 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrii Tkach, Dmitro Lisnichenko, Jaimin Jetly, Jayush Luniya, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-20434
> https://issues.apache.org/jira/browse/AMBARI-20434
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem:
> Kafka Service Check will create the kafka topic only if the topic doesn't exist.
> if it exists, Kafka Service Check will return success directly.
> After topic is being created, we sense that each time running service check will not reflect the kafka actual state correctly
>
> Suggestion:
> Every running kafka service check, delete the existed topic and recreate it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/service_check.py 0f3a417
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml 0275358
>
>
> Diff: https://reviews.apache.org/r/57580/diff/1/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Wang Jie
>
>