You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/28 14:19:46 UTC
[GitHub] [flink] gaborgsomogyi opened a new pull request, #21189: [FLINK-24119][tests] Add random to Kafka tests topic name
gaborgsomogyi opened a new pull request, #21189:
URL: https://github.com/apache/flink/pull/21189
## What is the purpose of the change
Kafka tests are having intermittent issues and because of that retry happens. The main issue is that when a test fails most of the time throws exception and topic almost never deleted. Such case test is 100% in a dead-end exception similar to this:
```
Oct 27 15:07:54 java.lang.AssertionError: Create test topic : partition_failure_recovery_EventTime failed, org.apache.kafka.common.errors.TopicExistsException: Topic 'partition_failure_recovery_EventTime' already exists.
```
In this PR I've added random to the Kafka topic names in the tests allowing to avoid such exception in the next round.
## Brief change log
Added random to the Kafka topic names in the tests
## Verifying this change
Existing unit tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21189:
URL: https://github.com/apache/flink/pull/21189#issuecomment-1295062961
cc @PatrickRen @MartijnVisser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name
Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #21189:
URL: https://github.com/apache/flink/pull/21189#issuecomment-1298495335
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi closed pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi closed pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name
URL: https://github.com/apache/flink/pull/21189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21189:
URL: https://github.com/apache/flink/pull/21189#issuecomment-1310215725
This alone is not solving the issue so closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name
Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #21189:
URL: https://github.com/apache/flink/pull/21189#issuecomment-1296277519
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21189:
URL: https://github.com/apache/flink/pull/21189#issuecomment-1295065992
Just some further hints, I've put https://github.com/apache/flink/pull/21180 into a loop and the changed test was never failed on my machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21189:
URL: https://github.com/apache/flink/pull/21189#issuecomment-1295067803
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4fb9b7b74f920ea8f777550134f77cd83243e62",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4fb9b7b74f920ea8f777550134f77cd83243e62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4fb9b7b74f920ea8f777550134f77cd83243e62 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21189:
URL: https://github.com/apache/flink/pull/21189#issuecomment-1295062319
Let's see how it looks like at all tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21189:
URL: https://github.com/apache/flink/pull/21189#issuecomment-1298537930
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21189:
URL: https://github.com/apache/flink/pull/21189#issuecomment-1295321903
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21189:
URL: https://github.com/apache/flink/pull/21189#issuecomment-1295349886
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org